Use immutable mappings and other cleanups#213
Merged
hmgaudecker merged 16 commits intomainfrom Jan 22, 2026
Merged
Conversation
…Use Mapping for type annotations.
…ingProxyType as a jax pytree.
timmens
approved these changes
Jan 22, 2026
Member
timmens
left a comment
There was a problem hiding this comment.
Very nice actually! Thanks a lot 🎉
No showstoppers, the only thing I noticed is that the CLAUDE.md file seems to be outdated with regard to some of the API changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
dictbyMappingProxyType, useMappingfor annotations. Note: These changes require dags #67namefield fromRegime. We now just passregimes={"alive": regime_a, "dead": regime_b}. In the initialisation ofModel, we make sure its keys and the fields ofregime_id_classline up. Then do everything based on a mapping ofregime_names_to_ids. Gets rid of the awkward typing we had before.if TYPE_CHECKINGentirely -- too much developer time is being spent on this in Python 3.14 at essentially no runtime gain