Some deferred observers get destroyed during updates#20
Open
francisduffy wants to merge 1 commit intoOpenSourceRisk:masterfrom
Open
Some deferred observers get destroyed during updates#20francisduffy wants to merge 1 commit intoOpenSourceRisk:masterfrom
francisduffy wants to merge 1 commit intoOpenSourceRisk:masterfrom
Conversation
Adding the changes from PR 2409 and 2412 that avoid dereferencing elements of deferredObservers_ that become null during ObservableSettings::enableUpdates(). This is discussed in PR 326 of ORE: OpenSourceRisk/Engine#326.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the changes from PR lballabio#2409 and PR lballabio#2412 that avoid dereferencing elements of
deferredObservers_that become null duringObservableSettings::enableUpdates().The change here is discussed in pull request OpenSourceRisk/Engine#326.