feat: Add listener for inject audit context in jobs #101
+912
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrestejerina97
force-pushed
the
feature/replicate-context-in-job-v2
branch
4 times, most recently
from
f32ffd5 to
57e515e
Compare
andrestejerina97
force-pushed
the
feature/replicate-context-in-job-v2
branch
from
57e515e to
8b96c9b
Compare
matiasperrone-exo
changed the title
caseylocker
previously requested changes
Feb 2, 2026
Contributor
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
In CleanupJobAuditContextListener is only attached to the JobProcessed event. If a job fails before completion, the context may persist and pollute the next job data. Add a cleanup on failure as well: JobFailed and JobExceptionOccurred.
Collaborator
|
@andrestejerina97 any update on #101 (review) ? |
Contributor
Author
|
Thanks @caseylocker i have updated with new changes |
smarcet
reviewed
Feb 4, 2026
smarcet
reviewed
Feb 4, 2026
smarcet
requested changes
Feb 4, 2026
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@andrestejerina97 please review comments
Contributor
Author
|
@smarcet new changes to review |
|
Please can you review this @caseylocker @romanetar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement to obtain the audit context in a worker's job. The idea is to attack the listener just before the job is sent, inject the context of the request into the payload, and then, just before starting processing, pass the context to the app container.
ref: https://app.clickup.com/t/86b892wkn