Adding europe asia button section to osf homepage#531
Open
PeteShine1 wants to merge 4 commits intomasterfrom
Open
Adding europe asia button section to osf homepage#531PeteShine1 wants to merge 4 commits intomasterfrom
PeteShine1 wants to merge 4 commits intomasterfrom
Conversation
Contributor
|
@PeteShine1 .env.template should not be deleted is a reference |
Contributor
|
@PeteShine1 also src/content/settings.json should be removed from the PR |
Contributor
|
@PeteShine1 .python-version should be added to .gitignore and removed from this PR |
smarcet
requested changes
Dec 5, 2023
Contributor
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@PeteShine1 please review comments
Contributor
|
@PeteShine1 also check logs build error |
smarcet
reviewed
Dec 5, 2023
Contributor
Author
|
In this last PR, I also took .env and .env* out of .gitignore, in an attempt to resolve #531 (comment) |
smarcet
force-pushed
the
master
branch
2 times, most recently
from
6e6c904 to
c30966c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asia and Europe site buttons added above news section.