Conversation
rascmatt
force-pushed
the
feat/rtl-test-image
branch
2 times, most recently
from
a691962 to
71f9c73
Compare
rascmatt
force-pushed
the
feat/rtl-test-image
branch
from
6790b44 to
39295a9
Compare
rascmatt
commented
Dec 3, 2025
- refactor firtool build image - prepare dependencies for test-base image
rascmatt
force-pushed
the
feat/rtl-test-image
branch
from
53fd253 to
5cfdc25
Compare
linushdot
approved these changes
Dec 5, 2025
Contributor
linushdot
left a comment
linushdot
left a comment
There was a problem hiding this comment.
LGTM. Thanks for integrating the first hardware tests into CI!
Contributor
Author
|
Benchmarks are in the pipeline too :) #593 |
AndreasKrall
pushed a commit
that referenced
this pull request
Dec 24, 2025
* rtl: prepare RTL test base - refactor firtool build image - prepare dependencies for test-base image * rtl: Integrate RTL tests into openvadl tests * fix: checkstyle issue * rtl: Add build action for rtl-test-base image * rtl: Fix signal name conflict * rtl: Add image digest to firtool image import * rtl: Use ghcr rtl-test-base image * ci: Add test-rtl task to CI workflow * rtl: Use latest rtl-test-base image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add docker-based RTL tests.
The rtl-base image is set up with the risc-v test suite (https://github.com/riscv/riscv-tests) already checked out and pre-built at
/riscv-tests. The test setup then copies/mounts theopenvadl rtloutput to/rtl.To actually execute the test suite I'm also using a bash script, which allows for lots of flexibility. I think this will particularly useful when implementing the automated benchmarking/evaluation.