Merged
Conversation
wvpm
force-pushed
the
refactor_ruleset
branch
4 times, most recently
from
41c489a to
8c4d682
Compare
schombert
reviewed
Feb 18, 2026
wvpm
force-pushed
the
refactor_ruleset
branch
4 times, most recently
from
1e21716 to
7651491
Compare
wvpm
force-pushed
the
refactor_ruleset
branch
from
7651491 to
aa18813
Compare
wvpm
force-pushed
the
refactor_ruleset
branch
2 times, most recently
from
9330856 to
6b72836
Compare
Spartan322
reviewed
Feb 18, 2026
Spartan322
reviewed
Feb 18, 2026
Spartan322
reviewed
Feb 18, 2026
wvpm
force-pushed
the
refactor_ruleset
branch
from
6b72836 to
5b9149f
Compare
Spartan322
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rules in Victoria 2 are completely hardcoded. You can't add any without changing the sim binary. So I'm making it all hardcoded.
The way conflicting or unspecified rules are resolved is as follows:
same_as_ruling_party = yes&rich_only = yes,same_as_ruling_partyapplied. So I'm applying them in order of enum value.Resolving conflicting or missing values is logged either as warning or error depending on the severity of the conflict.
Mutually exclusive rules set to yes is an error. The rest is a warning.