Skip to content

Add createdBy, updatedBy, createdAt, updatedAt in DTOs #4415#4443

Merged
burgerni10 merged 9 commits intorelease/3.8from
add-created-by-updated-by-created-at-updated-at-in-dtos#4415
Mar 25, 2026
Merged

Add createdBy, updatedBy, createdAt, updatedAt in DTOs #4415#4443
burgerni10 merged 9 commits intorelease/3.8from
add-created-by-updated-by-created-at-updated-at-in-dtos#4415

Conversation

@kbalinthunor
Copy link
Copy Markdown
Collaborator

@kbalinthunor kbalinthunor commented Mar 10, 2026

UI before the changes:
image
image
image
image

UI after the changes:
image
image
image
image
image

Closes #4415

@burgerni10 burgerni10 force-pushed the add-created-by-updated-by-created-at-updated-at-in-dtos#4415 branch 2 times, most recently from 42d9b42 to fc6d3e7 Compare March 13, 2026 07:53
Copy link
Copy Markdown
Collaborator

@burgerni10 burgerni10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of showing the user ID, let's display the user login (or 'OIAnalytics' if the id is OIAnalytics). To do so, let's directly add a userFriendlyName in the DTOs. The friendlyName is firstName lastName (login) (see comment)

Show the hours and minutes in the createdAt, updatedAt display. You can use |datetime:ff pipe option (I think) to display it.

Comment thread backend/src/model/types.ts Outdated
Comment thread backend/src/repository/config/scan-mode.repository.ts Outdated
Comment thread backend/src/service/certificate.service.ts Outdated
Comment thread frontend/src/app/shared/datetime.pipe.ts Outdated
Comment thread frontend/src/app/shared/datetime.pipe.ts Outdated
@burgerni10 burgerni10 force-pushed the add-created-by-updated-by-created-at-updated-at-in-dtos#4415 branch from 2f35805 to 2982fdb Compare March 19, 2026 10:01
Comment thread backend/src/repository/config/engine.repository.ts Outdated
Comment thread backend/src/repository/config/history-query.repository.ts Outdated
Comment thread backend/src/repository/config/oianalytics-message.repository.ts Outdated
Comment thread backend/src/repository/config/oianalytics-registration.repository.ts Outdated
Comment thread backend/src/repository/config/scan-mode.repository.ts Outdated
Comment thread backend/src/repository/config/user.repository.ts Outdated
Copy link
Copy Markdown
Collaborator

@burgerni10 burgerni10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changes, some are in separate issues but you can fix them in the same PR if you want.

Overall, avoid the use of unknown outside tests, and make sure every entity has a createdBy, updatedBy, createdAt, updatedAt.

I've rebased your branch and merge the migration in 3.8

Comment thread backend/src/service/oia/oianalytics-message.service.ts
Comment thread backend/src/service/oia/oianalytics-message.service.ts
Comment thread backend/src/service/oia/oianalytics-command.service.ts Outdated
Comment thread backend/src/service/oia/oianalytics-command.service.ts Outdated
Comment thread backend/src/service/certificate.service.ts Outdated
Comment thread backend/src/service/oibus.service.spec.ts Outdated
Comment thread backend/src/service/oibus.service.ts Outdated
Comment thread backend/src/service/user.service.ts
Comment thread backend/src/service/user.service.ts
Comment thread backend/src/tests/utils/test-utils.ts Outdated
@burgerni10 burgerni10 force-pushed the add-created-by-updated-by-created-at-updated-at-in-dtos#4415 branch 2 times, most recently from 7a94210 to 6e4816e Compare March 19, 2026 16:08
@burgerni10 burgerni10 force-pushed the add-created-by-updated-by-created-at-updated-at-in-dtos#4415 branch from 6e4816e to d48bfc0 Compare March 20, 2026 11:16
@burgerni10 burgerni10 force-pushed the add-created-by-updated-by-created-at-updated-at-in-dtos#4415 branch 2 times, most recently from 0098538 to 174607e Compare March 25, 2026 10:53
@burgerni10 burgerni10 force-pushed the add-created-by-updated-by-created-at-updated-at-in-dtos#4415 branch from 174607e to ffb20a2 Compare March 25, 2026 11:02
@burgerni10 burgerni10 merged commit 770102a into release/3.8 Mar 25, 2026
2 checks passed
@burgerni10 burgerni10 deleted the add-created-by-updated-by-created-at-updated-at-in-dtos#4415 branch March 25, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants