build: invalidate certain cargo-install caches, fixing Win build pt 2 #5346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so close, looks like just one more cache ( |
|
I just wiped them all, will try again! |
|
It's so close, now! https://github.com/PRQL/prql/actions/runs/16014368312/job/45178110951?pr=5346#step:15:880 Looks like the doctests somehow also need the linker patch. |
|
I'm not sure why setting RUSTFLAGS didn't have any effect on the doctest compilation failure. Cross fingers that the upstream regression gets fixed, then we don't need this. rust-lang/rust#141626 (comment) |
|
@kgutwin windows now seems to pass on main! |
|
wait, are you sure? I still see this failure from the most recent "tests" run on main: https://github.com/PRQL/prql/actions/runs/16300971426/job/46035208345 |
|
bah you're right! I'm not sure why it shows green here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took one last look at the Windows build failure messages, and this is another stab at maybe fixing them. Hopefully invalidating the
baptiste0928/cargo-install@v3caches forcargo-instaandwasm-packwill let Windows rebuild and properly use those tools...