🩹 [Patch]: Optimize Connect-GitHubApp and use parallel processing of access tokens

.github/PSModule.yml

@@ -1,17 +1,17 @@
 Test:
   CodeCoverage:
     PercentTarget: 50
-#   TestResults:
-#     Skip: true
-#   SourceCode:
-#     Skip: true
-#   PSModule:
-#     Skip: true
-#   Module:
-#     Windows:
-#       Skip: true
-#     MacOS:
-#       Skip: true
-# Build:
-#   Docs:
-#     Skip: true
+  TestResults:
+    Skip: true
+  SourceCode:
+    Skip: true
+  PSModule:
+    Skip: true
+  Module:
+    Windows:
+      Skip: true
+    MacOS:
+      Skip: true
+Build:
+  Docs:
+    Skip: true

src/classes/public/App/GitHubApp.ps1

@@ -45,19 +45,19 @@
 
     GitHubApp([object]$Object) {
         $this.ID = $Object.id
-        $this.ClientID = $Object.client_id
+        $this.ClientID = $Object.client_id ?? $Object.ClientID
         $this.Slug = $Object.app_slug ?? $Object.slug
-        $this.NodeID = $Object.node_id
+        $this.NodeID = $Object.node_id ?? $Object.NodeID
         $this.Owner = [GitHubOwner]::new($Object.owner)
         $this.Name = $Object.name
         $this.Description = $Object.description
-        $this.ExternalUrl = $Object.external_url
-        $this.Url = $Object.html_url
-        $this.CreatedAt = $Object.created_at
-        $this.UpdatedAt = $Object.updated_at
+        $this.ExternalUrl = $Object.external_url ?? $Object.ExternalUrl
+        $this.Url = $Object.html_url ?? $Object.Url
+        $this.CreatedAt = $Object.created_at ?? $Object.createdAt
+        $this.UpdatedAt = $Object.updated_at ?? $Object.updatedAt
         $this.Permissions = [GitHubPermission]::NewPermissionList($Object.permissions)
         $this.Events = , ($Object.events)
-        $this.Installations = $Object.installations_count
+        $this.Installations = $Object.installations_count ?? $Object.Installations
     }
 
     [string] ToString() {

src/classes/public/App/GitHubAppInstallation.ps1

@@ -48,13 +48,21 @@
 
     GitHubAppInstallation([PSCustomObject] $Object) {
         $this.ID = $Object.id
-        $this.App = [GitHubApp]::new(
-            [PSCustomObject]@{
-                client_id = $Object.client_id
-                app_slug  = $Object.app_slug
+        $this.App = if ($null -ne $Object.App) {
+            $Object.App
+        } else {
+            [GitHubApp]@{
+                ClientID = $Object.client_id
+                Slug     = $Object.app_slug
             }
-        )
-        $this.Target = [GitHubOwner]::new($Object.account)
+        }
+        $this.Target = if ($null -ne $Object.Target) {
+            [GitHubOwner]::new($Object.Target)
+        } elseif ($null -ne $Object.Account) {
+            [GitHubOwner]::new($Object.Account)
+        } else {
+            $null
+        }
         $this.Type = $Object.target_type
         $this.RepositorySelection = $Object.repository_selection
         $this.Permissions = [GitHubPermission]::NewPermissionList($Object.permissions, $this.Type)
@@ -65,7 +73,7 @@
         $this.SuspendedAt = $Object.suspended_at
         $this.SuspendedBy = [GitHubUser]::new($Object.suspended_by)
         $this.Url = $Object.html_url
-        $this.Status = 'Unknown'
+        $this.Status = $Object.Status ?? 'Unknown'
     }
 
     GitHubAppInstallation([PSCustomObject] $Object, [GitHubApp] $App) {
@@ -87,12 +95,10 @@
 
     GitHubAppInstallation([PSCustomObject] $Object, [string] $Target, [string] $Type, [string] $HostName) {
         $this.ID = $Object.id
-        $this.App = [GitHubApp]::new(
-            [PSCustomObject]@{
-                client_id = $Object.client_id
-                app_slug  = $Object.app_slug
-            }
-        )
+        $this.App = [GitHubApp]@{
+            ClientID = $Object.client_id
+            Slug     = $Object.app_slug
+        }
         $this.Target = [GitHubOwner]@{
             Name = $Target
             Type = $Type
@@ -111,7 +117,7 @@
         $this.Status = 'Unknown'
     }
 
-    # Updates the Status property by comparing installation permissions with app permissions
+    # Sets the Status property by comparing installation permissions with app permissions
     # filtered by the appropriate scope based on installation type
     [void] SetStatus() {
         if (-not $this.App -or -not $this.App.Permissions) {

src/classes/public/Context/GitHubContext/GitHubAppContext.ps1

@@ -1,4 +1,7 @@
 class GitHubAppContext : GitHubContext {
+    # The App that this context represents.
+    [GitHubApp] $App
+
     # Client ID for GitHub Apps
     [string] $ClientID
 
@@ -51,5 +54,8 @@
             $this.Permissions = [GitHubPermission]::NewPermissionList($Object.Permissions)
         }
         $this.Events = , ($Object.Events)
+        if ($Object.App) {
+            $this.App = [GitHubApp]::New($Object.App)
+        }
     }
 }

src/classes/public/GitHubPlan.ps1

@@ -27,11 +27,11 @@
 
     GitHubPlan([PSCustomObject]$Object) {
         $this.Name = $Object.name
-        $this.PrivateRepos = $Object.private_repos
+        $this.PrivateRepos = $Object.private_repos ?? $Object.PrivateRepos
         $this.Collaborators = $Object.collaborators
         $this.Space = $Object.space
         $this.Seats = $Object.seats
-        $this.FilledSeats = $Object.filled_seats
+        $this.FilledSeats = $Object.filled_seats ?? $Object.FilledSeats
     }
 
     [string] ToString() {

src/classes/public/Owner/GitHubOwner.ps1

@@ -43,20 +43,20 @@
 
     GitHubOwner([PSCustomObject]$Object) {
         # From GitHubNode
-        $this.ID = $Object.id
-        $this.NodeID = $Object.node_id
+        $this.ID = $Object.databaseId ?? $Object.id
+        $this.NodeID = $Object.node_id ?? $Object.NodeID ?? $Object.id
 
         # From GitHubOwner
-        $this.Name = $Object.slug ?? $Object.login
-        $this.DisplayName = $Object.name
-        $this.AvatarUrl = $Object.avatar_url
+        $this.Name = $Object.slug ?? $Object.login ?? $Object.name
+        $this.DisplayName = $Object.DisplayName ?? $Object.name
+        $this.AvatarUrl = $Object.avatar_url ?? $Object.AvatarUrl
         $this.Url = $Object.html_url ?? $Object.url
         $this.Type = $Object.type
         $this.Location = $Object.location
         $this.Description = $Object.description ?? $Object.bio
-        $this.Website = $Object.websiteUrl ?? $Object.blog
-        $this.CreatedAt = $Object.created_at
-        $this.UpdatedAt = $Object.updated_at
+        $this.Website = $Object.websiteUrl ?? $Object.blog ?? $Object.Website
+        $this.CreatedAt = $Object.created_at ?? $Object.createdAt
+        $this.UpdatedAt = $Object.updated_at ?? $Object.updatedAt
     }
 
     [string] ToString() {

src/classes/public/Owner/GitHubOwner/GitHubEnterprise.ps1

@@ -27,18 +27,18 @@
 
     GitHubEnterprise([PSCustomObject] $Object) {
         # From GitHubNode
-        $this.ID = $Object.databaseId
-        $this.NodeID = $Object.id
+        $this.ID = $Object.databaseId ?? $Object.id
+        $this.NodeID = $Object.node_id ?? $Object.NodeID ?? $Object.id
 
         # From GitHubOwner
-        $this.Name = $Object.slug
-        $this.DisplayName = $Object.name
+        $this.Name = $Object.slug ?? $Object.Name
+        $this.DisplayName = $Object.name ?? $this.DisplayName
         $this.AvatarUrl = $Object.avatarUrl
         $this.Url = $Object.url
         $this.Type = $Object.type ?? 'Enterprise'
         $this.Location = $Object.location
         $this.Description = $Object.description
-        $this.Website = $Object.websiteUrl
+        $this.Website = $Object.websiteUrl ?? $Object.Website
         $this.CreatedAt = $Object.createdAt
         $this.UpdatedAt = $Object.updatedAt
 

src/classes/public/Owner/GitHubOwner/GitHubOrganization.ps1

@@ -181,16 +181,26 @@
 
     GitHubOrganization() {}
 
-    GitHubOrganization([PSCustomObject] $Object, [GitHubContext] $Context) {
+    GitHubOrganization([PSCustomObject] $Object) {
+        $this.InitializeFromObject($Object)
+    }
+
+    GitHubOrganization([PSCustomObject] $Object, [string] $Url) {
+        $this.InitializeFromObject($Object)
+        # Override URL with provided value
+        $this.Url = $Url
+    }
+
+    hidden [void] InitializeFromObject([PSCustomObject] $Object) {
         # From GitHubNode
         $this.ID = $Object.databaseId ?? $Object.id
-        $this.NodeID = $Object.node_id ?? $Object.id
+        $this.NodeID = $Object.node_id ?? $Object.NodeID ?? $Object.id
 
         # From GitHubOwner
-        $this.Name = $Object.login
-        $this.DisplayName = $Object.name
+        $this.Name = $Object.login ?? $this.Name
+        $this.DisplayName = $Object.name ?? $Object.DisplayName
         $this.AvatarUrl = $Object.avatar_url ?? $Object.avatarUrl
-        $this.Url = $Object.html_url ?? $Object.url ?? "https://$($Context.HostName)/$($Object.login)"
+        $this.Url = $Object.html_url ?? $Object.url
         $this.Type = $Object.type ?? 'Organization'
         $this.Location = $Object.location
         $this.Description = $Object.description
@@ -202,44 +212,56 @@
         $this.Email = $Object.email
         $this.TwitterUsername = $Object.twitter_username ?? $Object.twitterUsername
         $this.Plan = [GitHubPlan]::New($Object.plan)
-        $this.PublicRepos = $Object.public_repos
-        $this.PublicGists = $Object.public_gists
+        $this.PublicRepos = $Object.public_repos ?? $Object.PublicRepos
+        $this.PublicGists = $Object.public_gists ?? $Object.PublicGists
         $this.Followers = $Object.followers
         $this.Following = $Object.following
-        $this.PrivateGists = $Object.total_private_gists
-        $this.TotalPrivateRepos = $Object.total_private_repos
-        $this.OwnedPrivateRepos = $Object.owned_private_repos
-        if ($null -ne $Object.disk_usage) {
-            $this.Size = [uint64]($Object.disk_usage * 1KB)
+        $this.PrivateGists = $Object.total_private_gists ?? $Object.PrivateGists
+        $this.TotalPrivateRepos = $Object.total_private_repos ?? $Object.TotalPrivateRepos
+        $this.OwnedPrivateRepos = $Object.owned_private_repos ?? $Object.OwnedPrivateRepos
+        $this.Size = if ($null -ne $Object.disk_usage) {
+            [uint64]($Object.disk_usage * 1KB)
+        } else {
+            $Object.Size
         }
         $this.Collaborators = $Object.collaborators
         $this.IsVerified = $Object.is_verified ?? $Object.isVerified
-        $this.HasOrganizationProjects = $Object.has_organization_projects
-        $this.HasRepositoryProjects = $Object.has_repository_projects
-        $this.BillingEmail = $Object.billing_email
-        $this.DefaultRepositoryPermission = $Object.default_repository_permission
-        $this.MembersCanCreateRepositories = $Object.members_can_create_repositories
-        $this.RequiresTwoFactorAuthentication = $Object.two_factor_requirement_enabled ?? $Object.requiresTwoFactorAuthentication
-        $this.MembersAllowedRepositoryCreationType = $Object.members_allowed_repository_creation_type
-        $this.MembersCanCreatePublicRepositories = $Object.members_can_create_public_repositories
-        $this.MembersCanCreatePrivateRepositories = $Object.members_can_create_private_repositories
-        $this.MembersCanCreateInternalRepositories = $Object.members_can_create_internal_repositories
-        $this.MembersCanInviteCollaborators = $Object.members_can_invite_collaborators
-        $this.MembersCanCreatePages = $Object.members_can_create_pages
+        $this.HasOrganizationProjects = $Object.has_organization_projects ?? $Object.HasOrganizationProjects
+        $this.HasRepositoryProjects = $Object.has_repository_projects ?? $Object.HasRepositoryProjects
+        $this.BillingEmail = $Object.billing_email ?? $Object.BillingEmail
+        $this.DefaultRepositoryPermission = $Object.default_repository_permission ?? $Object.DefaultRepositoryPermission
+        $this.MembersCanCreateRepositories = $Object.members_can_create_repositories ?? $Object.MembersCanCreateRepositories
+        $this.RequiresTwoFactorAuthentication = $Object.two_factor_requirement_enabled ?? $Object.requiresTwoFactorAuthentication ??
+        $Object.RequiresTwoFactorAuthentication
+        $this.MembersAllowedRepositoryCreationType = $Object.members_allowed_repository_creation_type ?? $Object.MembersAllowedRepositoryCreationType
+        $this.MembersCanCreatePublicRepositories = $Object.members_can_create_public_repositories ?? $Object.MembersCanCreatePublicRepositories
+        $this.MembersCanCreatePrivateRepositories = $Object.members_can_create_private_repositories ?? $Object.MembersCanCreatePrivateRepositories
+        $this.MembersCanCreateInternalRepositories = $Object.members_can_create_internal_repositories ?? $Object.MembersCanCreateInternalRepositories
+        $this.MembersCanInviteCollaborators = $Object.members_can_invite_collaborators ?? $Object.MembersCanInviteCollaborators
+        $this.MembersCanCreatePages = $Object.members_can_create_pages ?? $Object.MembersCanCreatePages
         $this.MembersCanForkPrivateRepositories = $Object.members_can_fork_private_repositories ?? $Object.membersCanForkPrivateRepositories
-        $this.RequireWebCommitSignoff = $Object.web_commit_signoff_required ?? $Object.webCommitSignoffRequired
-        $this.DeployKeysEnabledForRepositories = $Object.deploy_keys_enabled_for_repositories
-        $this.MembersCanCreatePublicPages = $Object.members_can_create_public_pages
-        $this.MembersCanCreatePrivatePages = $Object.members_can_create_private_pages
-        $this.AdvancedSecurityEnabledForNewRepositories = $Object.advanced_security_enabled_for_new_repositories
-        $this.DependabotAlertsEnabledForNewRepositories = $Object.dependabot_alerts_enabled_for_new_repositories
-        $this.DependabotSecurityUpdatesEnabledForNewRepositories = $Object.dependabot_security_updates_enabled_for_new_repositories
-        $this.DependencyGraphEnabledForNewRepositories = $Object.dependency_graph_enabled_for_new_repositories
-        $this.SecretScanningEnabledForNewRepositories = $Object.secret_scanning_enabled_for_new_repositories
-        $this.SecretScanningPushProtectionEnabledForNewRepositories = $Object.secret_scanning_push_protection_enabled_for_new_repositories
-        $this.SecretScanningPushProtectionCustomLinkEnabled = $Object.secret_scanning_push_protection_custom_link_enabled
-        $this.SecretScanningPushProtectionCustomLink = $Object.secret_scanning_push_protection_custom_link
-        $this.SecretScanningValidityChecksEnabled = $Object.secret_scanning_validity_checks_enabled
+        $this.RequireWebCommitSignoff = $Object.web_commit_signoff_required ?? $Object.webCommitSignoffRequired ?? $Object.RequireWebCommitSignoff
+        $this.DeployKeysEnabledForRepositories = $Object.deploy_keys_enabled_for_repositories ?? $Object.deployKeysEnabledForRepositories
+        $this.MembersCanCreatePublicPages = $Object.members_can_create_public_pages ?? $Object.MembersCanCreatePublicPages
+        $this.MembersCanCreatePrivatePages = $Object.members_can_create_private_pages ?? $Object.MembersCanCreatePrivatePages
+        $this.AdvancedSecurityEnabledForNewRepositories = $Object.advanced_security_enabled_for_new_repositories ??
+        $Object.advancedSecurityEnabledForNewRepositories
+        $this.DependabotAlertsEnabledForNewRepositories = $Object.dependabot_alerts_enabled_for_new_repositories ??
+        $Object.dependabotAlertsEnabledForNewRepositories
+        $this.DependabotSecurityUpdatesEnabledForNewRepositories = $Object.dependabot_security_updates_enabled_for_new_repositories ??
+        $Object.dependabotSecurityUpdatesEnabledForNewRepositories
+        $this.DependencyGraphEnabledForNewRepositories = $Object.dependency_graph_enabled_for_new_repositories ??
+        $Object.dependencyGraphEnabledForNewRepositories
+        $this.SecretScanningEnabledForNewRepositories = $Object.secret_scanning_enabled_for_new_repositories ??
+        $Object.secretScanningEnabledForNewRepositories
+        $this.SecretScanningPushProtectionEnabledForNewRepositories = $Object.secret_scanning_push_protection_enabled_for_new_repositories ??
+        $Object.secretScanningPushProtectionEnabledForNewRepositories
+        $this.SecretScanningPushProtectionCustomLinkEnabled = $Object.secret_scanning_push_protection_custom_link_enabled ??
+        $Object.secretScanningPushProtectionCustomLinkEnabled
+        $this.SecretScanningPushProtectionCustomLink = $Object.secret_scanning_push_protection_custom_link ??
+        $Object.secretScanningPushProtectionCustomLink
+        $this.SecretScanningValidityChecksEnabled = $Object.secret_scanning_validity_checks_enabled ??
+        $Object.secretScanningValidityChecksEnabled
         $this.ArchivedAt = $Object.archived_at ?? $Object.archivedAt
     }
 

src/classes/public/Owner/GitHubOwner/GitHubUser.ps1

@@ -42,31 +42,31 @@
 
     GitHubUser([PSCustomObject]$Object) {
         # From GitHubNode
-        $this.ID = $Object.id
-        $this.NodeID = $Object.node_id
+        $this.ID = $Object.databaseId ?? $Object.id
+        $this.NodeID = $Object.node_id ?? $Object.NodeID ?? $Object.id
 
         # From GitHubOwner
-        $this.Name = $Object.login
-        $this.DisplayName = $Object.name
-        $this.AvatarUrl = $Object.avatar_url
-        $this.Url = $Object.html_url
+        $this.Name = $Object.login ?? $Object.Name
+        $this.DisplayName = $Object.name ?? $Object.DisplayName
+        $this.AvatarUrl = $Object.avatar_url ?? $Object.AvatarUrl
+        $this.Url = $Object.html_url ?? $Object.Url
         $this.Type = $Object.type
         $this.Location = $Object.location
-        $this.Description = $Object.bio
-        $this.Website = $Object.blog
-        $this.CreatedAt = $Object.created_at
-        $this.UpdatedAt = $Object.updated_at
+        $this.Description = $Object.bio ?? $Object.Description
+        $this.Website = $Object.blog ?? $Object.Website
+        $this.CreatedAt = $Object.created_at ?? $Object.CreatedAt
+        $this.UpdatedAt = $Object.updated_at ?? $Object.UpdatedAt
 
         # From GitHubUser
         $this.Email = $Object.email
         $this.Hireable = $Object.hireable
         $this.Company = $Object.company
-        $this.TwitterUsername = $Object.twitter_username
-        $this.PublicRepos = $Object.public_repos
-        $this.PublicGists = $Object.public_gists
+        $this.TwitterUsername = $Object.twitter_username ?? $this.TwitterUsername
+        $this.PublicRepos = $Object.public_repos ?? $this.PublicRepos
+        $this.PublicGists = $Object.public_gists ?? $this.PublicGists
         $this.Followers = $Object.followers
         $this.Following = $Object.following
-        $this.NotificationEmail = $Object.notification_email
+        $this.NotificationEmail = $Object.notification_email ?? $this.NotificationEmail
         $this.Plan = [GitHubPlan]::New($Object.plan)
     }
 

src/functions/private/Apps/GitHub Apps/Get-GitHubAppInstallableOrganization.ps1

@@ -52,7 +52,7 @@
 
         Invoke-GitHubAPI @apiParams | ForEach-Object {
             foreach ($organization in $_.Response) {
-                [GitHubOrganization]::new($organization, $Context)
+                [GitHubOrganization]::New($organization, "$($Context.HostName)/$($organization.login)")
             }
         }
     }

src/functions/private/Apps/GitHub Apps/Get-GitHubAppInstallationForAuthenticatedAppAsList.ps1

@@ -46,12 +46,9 @@
             Context     = $Context
         }
 
-        # Get the authenticated app to compare permissions and events
-        $authenticatedApp = Get-GitHubAppAsAuthenticatedApp -Context $Context
-
         Invoke-GitHubAPI @apiParams | ForEach-Object {
             foreach ($installation in $_.Response) {
-                [GitHubAppInstallation]::new($installation, $authenticatedApp)
+                [GitHubAppInstallation]::new($installation, $Context.App)
             }
         }
     }