Skip to content

Upsample #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 5, 2023
Merged

Upsample #115

merged 14 commits into from
Jul 5, 2023

Conversation

LokeZhou
Copy link
Contributor

@LokeZhou LokeZhou commented Jun 21, 2023 •
edited
Loading

PR Docs

这些api均有映射文档

PR APIs

torch.nn.Upsample
torch.utils.data.SequentialSampler
torch.utils.cpp_extension.CUDAExtension
torch.utils.cpp_extension.CppExtension
torch.Tensor.is_sparse

@paddle-bot
Copy link

paddle-bot bot commented Jun 21, 2023

Thanks for your contribution!

@zhwesky2010
Copy link
Collaborator

PR Docs

torch.nn.Upsample torch.utils.data.SequentialSampler torch.utils.cpp_extension.CUDAExtension torch.utils.cpp_extension.CppExtension torch.Tensor.is_sparse

PR APIs

torch.nn.Upsample
torch.utils.data.SequentialSampler
torch.utils.cpp_extension.CUDAExtension
torch.utils.cpp_extension.CppExtension
torch.Tensor.is_sparse

PR描述直接放docs的PR链接，已经有了的就写 xxx已有映射文档

zhwesky2010
zhwesky2010 reviewed Jun 26, 2023
View reviewed changes
paconvert/api_matcher.py Outdated
return GenericMatcher.generate_code(self, kwargs)


class UtilsCppExtensionMatcher(BaseMatcher):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个直接用genericamatcher，如果你要删掉某个参数，可设置kwargs_change: name: ""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tests/test_Tensor_is_sparse.py Outdated
obj.run(pytorch_code, ["result"])


test_case_1()
Copy link
Collaborator

@zhwesky2010 zhwesky2010 Jun 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个需要删掉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

zhwesky2010
zhwesky2010 reviewed Jul 4, 2023
View reviewed changes
paconvert/api_matcher.py Outdated
return GenericMatcher.generate_code(self, kwargs)


class TensorIsSpareMatcher(BaseMatcher):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以起个公用一些的名字，这样其他人也可以复用了

就叫Attribute2Func吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tests/test_nn_Upsample.py Outdated
result = m(input)
"""
)
obj.run(pytorch_code, unsupport=True, reason="paddle unsupport")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个原因要写具体一点

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

zhwesky2010
zhwesky2010 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit fafdd56 into PaddlePaddle:master Jul 5, 2023
@LokeZhou LokeZhou deleted the upsample branch July 6, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LokeZhou @zhwesky2010