[CINN] Remove raw unary infer sym cc include#78658
[CINN] Remove raw unary infer sym cc include#78658ooooo-create wants to merge 1 commit intoPaddlePaddle:developfrom
Conversation
Co-authored-by: Codex <codex@openai.com>
|
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Pull request overview
This PR removes a raw .cc inclusion that was aggregating unary symbolic-shape inference into cinn_op_infer_sym.o, which could misattribute incremental coverage to the wrong object file.
Changes:
- Replace the source-level include of
unary_infer_sym.ccwith the proper header includeunary_infer_sym.h. - Make
cinn::dialect::Pool2dOpInferSymbolicShapedelegate directly topaddle::dialect::Pool2dOpInferSymbolicShapeto avoid relying on internal helpers from the included.cc. - Minor cleanup in
GetRealPadding: fix lambda name typo and avoid unnecessary copies by usingconst¶meters.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/unary_infer_sym.cc | Minor parameter/lambda cleanup in pooling padding inference helpers. |
| paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/cinn_op_infer_sym.cc | Remove raw .cc inclusion; reuse Paddle Pool2d symbolic-shape inference to decouple object files and coverage attribution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
目前经常需要开发者自己来证明这个文件的代码确实覆盖到了,例如: #78441 (comment) |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #78658 +/- ##
==========================================
Coverage ? 66.66%
==========================================
Files ? 2
Lines ? 3
Branches ? 0
==========================================
Hits ? 2
Misses ? 1
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PR Category
CINN
PR Types
Improvements
Description
该 PR 参考已关闭的 #78417,移除 cinn_op_infer_sym.cc 对 unary_infer_sym.cc 的源码级 include,避免同一份 unary 符号推导逻辑被聚合进 cinn_op_infer_sym.o,导致增量 coverage 命中归属到错误对象文件。
主要改动:
验证:prek 通过;按要求未在本地编译。
是否引起精度变化
否