Skip to content

Conversation

blindaa121
Copy link
Collaborator

@blindaa121 blindaa121 commented Mar 11, 2025

Description

This PR addresses a regression bug introduced in #1099 which caused Discriminator Tabs to not render. The bug was caused by an invalid check against empty Discriminator props children.

See #1106 for context.

How Has This Been Tested?

Tested with example spec in original issue and navigating to get-series-list, as well as ensuring that Discriminator tabs are still rendering as expected under our available Discriminator test examples.

Screenshots (if appropriate)

Screenshot 2025-03-10 at 6 52 28 PM

Screenshot 2025-03-11 at 11 07 38 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@blindaa121 blindaa121 self-assigned this Mar 11, 2025
Copy link

Size Change: +11.1 kB (+0.55%)

Total Size: 2.02 MB

Filename Size Change
demo/build/petstore/schemas/cat/index.html 36.8 kB +1.92 kB (+5.51%) 🔍
demo/build/petstore/schemas/dog/index.html 37.2 kB +2.07 kB (+5.9%) 🔍
demo/build/petstore/schemas/honeybee/index.html 37.3 kB +2.04 kB (+5.8%) 🔍
demo/build/petstore/schemas/pet/index.html 36.7 kB +2.53 kB (+7.4%) 🔍
demo/build/petstore/schemas/user/index.html 44.9 kB +2.53 kB (+5.98%) 🔍
ℹ️ View Unchanged
Filename Size
demo/.docusaurus/codeTranslations.json 2 B
demo/.docusaurus/docusaurus.config.mjs 13.9 kB
demo/.docusaurus/globalData.json 40.7 kB
demo/.docusaurus/i18n.json 267 B
demo/.docusaurus/registry.js 59.9 kB
demo/.docusaurus/routes.js 55.4 kB
demo/.docusaurus/routesChunkNames.json 23 kB
demo/.docusaurus/site-metadata.json 1.35 kB
demo/build/assets/css/styles.********.css 146 kB
demo/build/assets/js/main.********.js 672 kB
demo/build/assets/js/runtime~main.********.js 15.8 kB
demo/build/index.html 91.1 kB
demo/build/petstore/add-pet/index.html 27.5 kB
demo/build/petstore/create-user/index.html 21.6 kB
demo/build/petstore/create-users-with-array-input/index.html 21.6 kB
demo/build/petstore/create-users-with-list-input/index.html 21.6 kB
demo/build/petstore/delete-order/index.html 21.6 kB
demo/build/petstore/delete-pet/index.html 21.7 kB
demo/build/petstore/delete-user/index.html 21.9 kB
demo/build/petstore/find-pets-by-status/index.html 22.3 kB
demo/build/petstore/find-pets-by-tags/index.html 23 kB
demo/build/petstore/get-inventory/index.html 20.9 kB
demo/build/petstore/get-order-by-id/index.html 21.9 kB
demo/build/petstore/get-pet-by-id/index.html 22.5 kB
demo/build/petstore/get-user-by-name/index.html 22 kB
demo/build/petstore/login-user/index.html 22.5 kB
demo/build/petstore/logout-user/index.html 21.3 kB
demo/build/petstore/new-pet/index.html 21.9 kB
demo/build/petstore/pet/index.html 23.6 kB
demo/build/petstore/place-order/index.html 21.1 kB
demo/build/petstore/schemas/apiresponse/index.html 22.9 kB
demo/build/petstore/schemas/category/index.html 24 kB
demo/build/petstore/schemas/id/index.html 21 kB
demo/build/petstore/schemas/order/index.html 25.1 kB
demo/build/petstore/schemas/tag/index.html 22.4 kB
demo/build/petstore/store/index.html 21.6 kB
demo/build/petstore/subscribe-to-the-store-events/index.html 27.9 kB
demo/build/petstore/swagger-petstore-yaml/index.html 28 kB
demo/build/petstore/update-pet-with-form/index.html 21.8 kB
demo/build/petstore/update-pet/index.html 22.3 kB
demo/build/petstore/update-user/index.html 21.9 kB
demo/build/petstore/upload-file/index.html 21.7 kB
demo/build/petstore/user/index.html 22.5 kB

compressed-size-action

Copy link

Visit the preview URL for this PR (updated for commit 5a71263):

https://docusaurus-openapi-36b86--pr1108-at71721z.web.app

(expires Thu, 10 Apr 2025 18:13:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf293780ee827f578864d92193b8c2866acd459f

@blindaa121 blindaa121 merged commit 3b438c6 into main Mar 11, 2025
10 checks passed
@sserrata sserrata deleted the frontend/discriminator-bug-fix branch May 1, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant