-
Notifications
You must be signed in to change notification settings - Fork 295
feat: Implement authPersistence in ThemeConfig
#1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Implement authPersistence in ThemeConfig
#1240
Conversation
|
Visit the preview URL for this PR (updated for commit 9d90bab): https://docusaurus-openapi-36b86--pr1240-zj7362xc.web.app (expires Thu, 11 Dec 2025 15:08:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bf293780ee827f578864d92193b8c2866acd459f |
|
Hi @tayles, thanks for the PR! Please find my review and suggestions below: Critical
Minor (this one is optional since the type already existed before your PR)
Minor (optional but appreciated)
|
|
Thanks @sserrata for your review, I have addressed these issues apart from your last point:
I didn't quite understand what you mean by this sorry. I think the imports are already correctly sorted and accurate? I updated some of the other unrelated type-only imports in this file in There were 2 other things I wanted to ask:
|
Description
Implements
authPersistenceoption forThemeConfig, to allow disabling of sessionStorage persistence.sessionStorage(current behavior)falseto disable storageMotivation and Context
Resolves #1239
Also provides a workaround to resolve #1238
An
authPersistenceconfiguration option is mentioned in the v0.2.1 (Dec 5, 2021) changelog (https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/blob/main/CHANGELOG.md#021-dec-5-2021), and the configuration types are already in place, but it is not currently implemented in the latest version.How Has This Been Tested?
Add
authPersistence: falsetodocusaurus.config.ts:As a side effect, persistence of server variables will also be disabled by settings this to
false, as this uses the same persistence middleware.NOTE: The current types in https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/blob/main/packages/docusaurus-theme-openapi-docs/src/types.ts have a slight spelling mistake:
authPersistance. This has been renamed toauthPersistence.Types of changes
Checklist