fix: use unrelocated gson for interacting with unrelocated APIs #229
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues where plugins that relocate gson didn't work anymore because the previous changes in 7b025cd were not taking into account that some plugins might relocate gson.
|
Can confirm this fixes the issue for me of Adventure platform bukkit no longer sending messages. I would suggest keeping in a fallback / original code for people that do not shade in gson themselves though, to avoid a needless string serialize/deserialize. Thanks for making fix, I can at least use this patch as-is. |
|
the serializer has always supported relocated gson until the 1.21.6 commit broke it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues where plugins that relocate gson didn't work anymore because the previous changes in 7b025cd were not taking into account that some plugins might relocate gson.