Skip to content

Conversation

@AritraDey-Dev
Copy link
Member

Description

Currently, the Quarto workflow creates unexpected directories (https://github.com/PecanProject/pecan-documentation/tree/main/pr-3694-381c450d92f0921c3f3391bf6c10786ed7f35c16/rendered-demo-notebooks) in the documentation repo when triggered by merge queues for PRs.
This PR fixes the workflow triggers to align with book.yml and restricts deployment to specific branches.

For more context #3694 (comment) and #3694 (comment).

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@infotroph infotroph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed that before! What was that we were saying about pushing and hoping? 😅

@AritraDey-Dev
Copy link
Member Author

AritraDey-Dev commented Dec 5, 2025

No worries! It's partly my fault as well. Now we have two of those directories created because of PRs #3694 and #3670.
1 and 2.

It's better to clean them up from that repo as well.

@infotroph infotroph added this pull request to the merge queue Dec 5, 2025
@infotroph
Copy link
Member

I've opened PecanProject/pecan-documentation#17 to clean up the accidentally added directories -- let's hold off on merging it long enough to be sure no more are getting created 😄

@AritraDey-Dev
Copy link
Member Author

AritraDey-Dev commented Dec 5, 2025

Fixed. No directories are created this time: https://github.com/PecanProject/pecan/actions/runs/19974228490/job/57286257325. It didn’t commit the changes to that branch.

Merged via the queue into PecanProject:develop with commit b87f1a5 Dec 5, 2025
19 of 26 checks passed
@AritraDey-Dev AritraDey-Dev deleted the fix/push-for-specific-branch branch December 5, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants