This repository was archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-3122] Allow private transactions to access public state#1916
Open
josh-richardson wants to merge 10 commits intoPegaSysEng:masterfrom
Open
[PAN-3122] Allow private transactions to access public state#1916josh-richardson wants to merge 10 commits intoPegaSysEng:masterfrom
josh-richardson wants to merge 10 commits intoPegaSysEng:masterfrom
Conversation
…n create public contract from private contract
…nsactions/contracts
josh-richardson
force-pushed
the
pan-3122
branch
from
8cfac99 to
4fce9fb
Compare
iikirilov
suggested changes
Sep 11, 2019
Contributor
iikirilov
left a comment
iikirilov
left a comment
There was a problem hiding this comment.
Need to clarify some dubious code in the ReadOnlyMutableAccount
...java/tech/pegasys/pantheon/tests/web3j/privacy/PrivateContractPublicStateAcceptanceTest.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| public NavigableMap<Bytes32, AccountStorageEntry> storageEntriesFrom( |
Contributor
There was a problem hiding this comment.
We need to double-check this
...e/src/main/java/tech/pegasys/pantheon/ethereum/mainnet/MainnetContractCreationProcessor.java
Outdated
Show resolved
Hide resolved
...java/tech/pegasys/pantheon/tests/web3j/privacy/PrivateContractPublicStateAcceptanceTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public void setNonce(final long value) { | ||
| throw new UnsupportedOperationException(); |
Contributor
There was a problem hiding this comment.
What are the implications of this if a new OPCode is added that we don't private contracts to call in the public state?
Contributor
Author
There was a problem hiding this comment.
We get into quite a nasty situation where pantheon tries to re-evaluate this over and over.
josh-richardson
force-pushed
the
pan-3122
branch
2 times, most recently
from
34066bd to
172cde1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
This allows private contract calls to access public state, meaning that a private contract a can retrieve data from a public contract b. Any operations which change state are disallowed.
Further details here: https://pegasys1.atlassian.net/browse/PAN-3122