zygiskd code cleanup #259
Merged
zygiskd code cleanup #259
+82
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Added `.clangd` to `.gitignore`. - Removed last semicolon in some macros. - Fixed invisibility clangd warning in `root_impl/*.h` by including the header which declares `root_impl_state`. - Added some system header includes where necessary to appease some compilers & linters. - Replaced hardcoded `bool` definition with the inclusion of C99's `<stdbool.h>`.
Some changes made possible with SonarLint. Changes: - Included some headers where appropriate, and removed unused ones. - Removed redundant casts (c:S1905). - Using pointers-to-const when adequate, for the sake of maintainability (c:S995 and c:S5350). - Cleaned trailing whitespace.
Changes: - Replaced `strtok()` with its reentrant alternative `strtok_r()` (c:S1912). - Fixed a memory leak with `strdup()` in `_apatch_get_package_config()`. - Addressed nullable values being passed to non-null parameters. - Dropped `const`-qualifier in `mountinfo` string members, since they are created, modified and used during execution. - Removed redundant casts.
ThePedroo
requested changes
Nov 25, 2025
Changes: - Moved a variable declaration to its next scope. - Removed useless boundaries check.
ThePedroo
reviewed
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
strtok()=>strtok_r()) to avoid UB in the existence of interruptions.constcasts, added otherconstcasts and removed redundant casts.includes.Why
Better stability, less memory leaks and more maintainable code.
Checkmarks