Round up hp when displaying it #2309
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntegratedQuantum
requested changes
Nov 19, 2025
| if(health + 0.5 < main.game.Player.super.health) { | ||
| heartTexture.bindTo(0); | ||
| } else if(health + 0.5 <= main.game.Player.super.health) { | ||
| } else if(health < main.game.Player.super.health) { |
Member
There was a problem hiding this comment.
Honestly this whole construct is rather confusing. Would you mind cleaning it up a little while you are at it?
Ideally it should be separate loops, one for full hearts, one for empty hearts and one if for the half heart. With the number computed upfront.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2308.
The healthbar now displays the health rounded up, which prevents it from displaying as 0 when the player's health is above 0.