Skip to content

auth Lua health checks: more responsiveness #16389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miodvallat wants to merge 3 commits into
base: master
Choose a base branch
from
Open

auth Lua health checks: more responsiveness #16389

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2615c6
Create the lua health check thread after giving it work to do, not be…
miodvallat Oct 29, 2025
2c05446
Make sure the health check thread checks for new work every second.
miodvallat Oct 29, 2025
bd30b08
Use a condition variable to signal the checker thread.
miodvallat Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pdns/lua-record.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,10 @@ class IsUpOracle
// set thread name again, in case std::async surprised us by doing work in this thread
setThreadName("pdns/luaupcheck");

std::this_thread::sleep_until(checkStart + std::chrono::seconds(interval));
// Only sleep for 1 second here, even if the health check interval is
// larger, in case we get new entries to process in d_statuses in the
// meantime.
std::this_thread::sleep_for(std::chrono::seconds(1));
}
}

Expand Down