auth: Überbackend code cleanup #16542
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19757600681Details
💛 - Coveralls |
Member
the only thing using it appears to be a |
Habbie
reviewed
Nov 25, 2025
pdns/ueberbackend.cc
Outdated
| { | ||
| DLOG(g_log << "Ueber get() was called for a " << qtype << " record" << endl); | ||
| bool isMore = false; | ||
| while (d_hinterBackend != nullptr && !(isMore = d_hinterBackend->get(record))) { // this backend out of answers |
Member
There was a problem hiding this comment.
late note: this comment is missing a word
This allows making the current backend pointer private and makes the behaviour more explicit: - all backends will be queried in sequence. - as soon as one backend answers the given (qname, qtype) query, none of the remaining backends will be queried until the next UeberBackend::lookup call (which starts a fresh new query). Signed-off-by: Miod Vallat <[email protected]>
Signed-off-by: Miod Vallat <[email protected]>
Habbie
previously approved these changes
Nov 25, 2025
Signed-off-by: Miod Vallat <[email protected]>
miodvallat
force-pushed
the
aschung
branch
3 times, most recently
from
3e81f60 to
a212ab4
Compare
Signed-off-by: Miod Vallat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This apparently simple PR reworks the behaviour of the
handleinternal object ofUeberBackendto:lookupcall.It is not supposed to introduce any behaviour change. But it will help make further (possibly breaking) changes in
UeberBackendwith confidence.P.S.: do we really need to keep the
instancesatomic counter? It doesn't seem to be used by anything and its value is not retrievable either.Checklist
I have: