Introduce the concept of languages from the simplify branch
#4016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-prismjs-com ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DmitrySharabin
force-pushed
the
required-languages
branch
2 times, most recently
from
d0c92c6 to
cc84d16
Compare
It allows referencing required languages inside grammar definitions via the `language` property of an options object passed to the `grammar()` function. So, we don't need to expose the `getLanguage()` function to grammar authors. ### Summary - Don't pass `getLanguage()` to the `grammar()` function - Don't mutate the language proto when the base grammar is specified (firstly, it's a bug, secondly, we don't want to define the base language as a property of the `languages` object—it's for the required languages only) - Add new utility functions for working with objects (authored by @LeaVerou) - Improve the type system to support the updated signature of `grammar()` - Update definitions of languages previously relied on `getLanguage()` Co-authored-by: Lea Verou <[email protected]>
DmitrySharabin
force-pushed
the
required-languages
branch
from
cc84d16 to
4641d1a
Compare
This was referenced Oct 10, 2025
LeaVerou
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows referencing required languages inside grammar definitions via the
languageproperty of an options object passed to thegrammar()function. So, we don't need to expose thegetLanguage()function to grammar authors.Summary
getLanguage()to thegrammar()functionlanguagesobject—it's for the required languages only)grammar()getLanguage()This is part 1 of 3 in a stack made with GitButler:
simplifybranch #4019languagesfrom thesimplifybranch #4016 👈