Types and optional quotes #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not the best implementation possible, but i didn't want to modify the module structure
|
can you add a test showing how things work better now ? |
|
Minecraft simply rejects the file without quotes and loads a backup from somewhere. Or you mean the quotes themselves, like {a:qwe} => {"a":"qwe"} ? |
|
Yes adding a test for both would be best This package code is complex, so it's important all new features are tested so the next PR doesn't break it |
Foresteam
force-pushed
the
master
branch
2 times, most recently
from
13eaff2 to
0a7b4c2
Compare
|
Correction: Minecraft 1.18.2 doesn't reject the file, it skips the "invalid" SNBT data. |
Foresteam
force-pushed
the
master
branch
2 times, most recently
from
e0bf799 to
e32aada
Compare
|
I think it's ready to be merged... For quite a long time |
For the original package...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minecraft may not read SNBT tags with no quotes (string values and names). It seem to always put them by default, also.