feat(chart): support appVersion as the default image tag #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@lengrongfu Can you help review this pr? |
Member
|
in this file |
xiongzubiao
force-pushed
the
appVersion
branch
2 times, most recently
from
3589c95 to
26cadb4
Compare
Author
Thanks for the review! |
xiongzubiao
force-pushed
the
appVersion
branch
from
26cadb4 to
9587034
Compare
Author
|
I force-pushed it to resolve the merging conflict. cc @wawa0210 @lengrongfu |
Signed-off-by: Zubiao Xiong <[email protected]>
xiongzubiao
force-pushed
the
appVersion
branch
from
9587034 to
033bc56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
It is common that helm charts use the
Chart.AppVersionas the default image tag. This PR adds support for it, while still allowing one to customize it viaValues.version.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: