Skip to content

Conversation

haitwang-cloud
Copy link
Contributor

Add NVIDIA k8s device plugin as a submodule and implement initial device plugin structure

What type of PR is this?
/kind feature

What this PR does / why we need it:

This pull request integrates the NVIDIA/k8s-device-plugin into the Project-HAMi/HAMi project. The integration involves adding the NVIDIA/k8s-device-plugin repository as a submodule, specifically the release-0.17 branch, and creating a script to update the submodule and copy the necessary files into the appropriate directories within the Project-HAMi/HAMi project.

Changes Made
Add NVIDIA k8s-device-plugin as a Submodule:

Added the NVIDIA/k8s-device-plugin repository as a submodule in the third_party/nvidia/k8s-device-plugin directory.
The submodule points to the release-0.17 branch.
Create Update Script:

Created a script named update_nvidia_plugin.sh to update the submodule to the latest version of the specified branch and copy the necessary files to the project's directories.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@haitwang-cloud haitwang-cloud marked this pull request as draft February 10, 2025 07:03
@haitwang-cloud haitwang-cloud force-pushed the update-nvidia-plugin branch 2 times, most recently from 05bd32a to 0a38996 Compare February 19, 2025 08:33
Copy link
Contributor

hami-robott bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haitwang-cloud
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robott hami-robott bot added the size/XXL label Feb 26, 2025
@haitwang-cloud haitwang-cloud force-pushed the update-nvidia-plugin branch 2 times, most recently from b893505 to d8ec2cd Compare March 18, 2025 08:57
Copy link
Contributor

hami-robott bot commented Mar 27, 2025

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • d50cb70 feat: implement stale lock detection and enhance node lock management
  • 5b638dd refactor: standardize variable naming for memory and lock management
  • a56b1b0 feat: enhance logging and improve device allocation handling in NVIDIA plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant