Skip to content

Conversation

Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented Feb 12, 2025

Fixes # .

Description

New Accelerated MAISI, inference only

Status

Ready/Work in progress/Hold

Please ensure all the checkboxes:

  • Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

Can-Zhao and others added 7 commits February 12, 2025 06:30
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao Can-Zhao requested a review from binliunls February 12, 2025 07:00
@Can-Zhao Can-Zhao marked this pull request as ready for review February 12, 2025 07:19
Can-Zhao and others added 17 commits February 12, 2025 07:25
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
…as issue, and it keps failing.

Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
…uality failed, will regenerate bsed on a new mask

Signed-off-by: Can-Zhao <[email protected]>
@binliunls
Copy link
Contributor

Hi @Can-Zhao could you please help to fix the code format issue

flake8
7.1.2 (flake8-bugbear: 24.12.12, flake8-comprehensions: 3.16.0,
flake8-executable: 2.1.3, mccabe: 0.7.0, pep8-naming: 0.14.1, pycodestyle:
2.12.1, pyflakes: 3.2.0) CPython 3.10.14 on Linux
/home/runner/work/model-zoo/model-zoo/models/maisi_ct_generative/scripts/sample.py:6[91](https://github.com/Project-MONAI/model-zoo/actions/runs/13884006366/job/38846235224?pr=726#step:7:92):13: F841 local variable 'try_time' is assigned to but never used
/home/runner/work/model-zoo/model-zoo/models/maisi_ct_generative/scripts/sample.py:733:17: F841 local variable 'to_generate' is assigned to but never used
2     F841 local variable 'try_time' is assigned to but never used
2
Check failed!

Signed-off-by: Can-Zhao <[email protected]>
@binliunls
Copy link
Contributor

Hi @Can-Zhao could you please take a look at the new CI issue?

Signed-off-by: Can-Zhao <[email protected]>
@yiheng-wang-nv yiheng-wang-nv enabled auto-merge (squash) March 18, 2025 05:35
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

blossom test failed in the download step: https://github.com/Project-MONAI/model-zoo/actions/runs/13916335849/job/38939964949

I will rerun to double confirm

@yiheng-wang-nv
Copy link
Collaborator

/build

Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator

/build

@Can-Zhao
Copy link
Collaborator Author

blossom test failed in the download step: https://github.com/Project-MONAI/model-zoo/actions/runs/13916335849/job/38939964949

I will rerun to double confirm

I forgot to add new model link. Just added. Thanks

@yiheng-wang-nv
Copy link
Collaborator

/build

1 similar comment
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

@yiheng-wang-nv
Copy link
Collaborator

Hi @Can-Zhao , since the weights file is changed to: all_steps1000size512ddpm_random_current_inputx_v1, train.json also needs to be updated

Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
Copy link
Collaborator Author

Hi @Can-Zhao , since the weights file is changed to: all_steps1000size512ddpm_random_current_inputx_v1, train.json also needs to be updated

I added back old ckpts. Should work now

@yiheng-wang-nv
Copy link
Collaborator

/build

Signed-off-by: Can-Zhao <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

@Can-Zhao
Copy link
Collaborator Author

still has error: https://github.com/Project-MONAI/model-zoo/actions/runs/13938702350/job/39011449556#step:2:5071

I see the reason. new workflow does not check body_region any more, so there will not be error for the body_region error test. I will modify the ci test case

Signed-off-by: Can-Zhao <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv yiheng-wang-nv merged commit d65df86 into Project-MONAI:dev Mar 19, 2025
4 checks passed
@Can-Zhao Can-Zhao deleted the maisi branch March 19, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants