Skip to content

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Mar 24, 2025

Description

Fixes #330

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

dependabot bot and others added 26 commits March 15, 2023 08:17
Bumps [actions/cache](https://github.com/actions/cache) from 3.2.2 to 3.3.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.2.2...v3.3.0)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [gittools/actions](https://github.com/gittools/actions) from 0.9.15 to 0.10.2.
- [Release notes](https://github.com/gittools/actions/releases)
- [Commits](GitTools/actions@v0.9.15...v0.10.2)

---
updated-dependencies:
- dependency-name: gittools/actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [AWSSDK.SecurityToken](https://github.com/aws/aws-sdk-net) from 3.7.101.22 to 3.7.101.24.
- [Release notes](https://github.com/aws/aws-sdk-net/releases)
- [Commits](https://github.com/aws/aws-sdk-net/commits)

---
updated-dependencies:
- dependency-name: AWSSDK.SecurityToken
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [AWSSDK.S3](https://github.com/aws/aws-sdk-net) from 3.7.103.24 to 3.7.103.27.
- [Release notes](https://github.com/aws/aws-sdk-net/releases)
- [Commits](https://github.com/aws/aws-sdk-net/commits)

---
updated-dependencies:
- dependency-name: AWSSDK.S3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
* Throw any error from MinIO when listing objects
* Capture ListObjectsAsync exceptions in VerifyObjectExistsAsync
* Configure minio client timeout
* Throw VerifyObjectsException on error
* Convert MinIO exception with custom exceptions
* Update API doc


Signed-off-by: Victor Chang <[email protected]>
+semver: patch

* Update dependencies: AWSSDK, GuardClauses, FluentAssertions, Moq, xunit, coverlet
* Update MinIo
* Update .NET6 libs
* Update licenses and dependency decisions

Signed-off-by: Victor Chang <[email protected]>
* Remove unused references
* Cleanup licenses
* Update Moq

Signed-off-by: Victor Chang <[email protected]>
* Upgrade to .NET 8

Signed-off-by: Victor Chang <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.1 to 3.1.4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3.1.1...v3.1.4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [apache/skywalking-eyes](https://github.com/apache/skywalking-eyes) from 0.4.0 to 0.5.0.
- [Release notes](https://github.com/apache/skywalking-eyes/releases)
- [Changelog](https://github.com/apache/skywalking-eyes/blob/main/CHANGES.md)
- [Commits](apache/skywalking-eyes@v0.4.0...v0.5.0)

---
updated-dependencies:
- dependency-name: apache/skywalking-eyes
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 3.3.0 to 3.3.2.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.3.0...v3.3.2)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 4.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3.1.2...v4.0.0)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update mc commands

Signed-off-by: Victor Chang <[email protected]>

* Update dependencies

Signed-off-by: Victor Chang <[email protected]>

* Remove windows build

Signed-off-by: Victor Chang <[email protected]>

* Update minio client for testing

Signed-off-by: Victor Chang <[email protected]>

* Update dependency versions

Signed-off-by: Victor Chang <[email protected]>

* Update 3rd party licenses and copyright

Signed-off-by: Victor Chang <[email protected]>

* Update licenses

Signed-off-by: Victor Chang <[email protected]>

---------

Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp added the build label Mar 24, 2025
@mocsharp mocsharp added this to the 1.0.2 milestone Mar 24, 2025
@mocsharp mocsharp self-assigned this Mar 24, 2025
@mocsharp mocsharp requested a review from dbericat March 24, 2025 22:34
@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.45114%. Comparing base (3478f9b) to head (e8e63b8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##                main        #331   +/-   ##
=============================================
  Coverage   79.45114%   79.45114%           
=============================================
  Files             38          38           
  Lines           1494        1494           
  Branches          78          78           
=============================================
  Hits            1187        1187           
  Misses           268         268           
  Partials          39          39           
Flag Coverage Δ
unittests 79.45114% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/MinIO/AmazonSecurityTokenServiceClientFactory.cs 0.00000% <ø> (ø)
src/Plugins/MinIO/ConfigurationKeys.cs 100.00000% <ø> (ø)
...ns/MinIO/Extensions/AccessPermissionsExtensions.cs 77.77778% <ø> (ø)
src/Plugins/MinIO/HealthCheckBuilder.cs 72.72727% <ø> (ø)
src/Plugins/MinIO/MinIoAdminHealthCheck.cs 62.50000% <ø> (ø)
src/Plugins/MinIO/MinIoClientFactory.cs 42.85714% <ø> (ø)
src/Plugins/MinIO/MinIoHealthCheck.cs 80.00000% <ø> (ø)
src/Plugins/MinIO/MinIoStartup.cs 88.88889% <ø> (ø)
src/Plugins/MinIO/MinIoStorageService.cs 68.63469% <ø> (ø)
src/Plugins/MinIO/ServiceRegistration.cs 100.00000% <ø> (ø)
... and 28 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3478f9b...e8e63b8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@MMelQin MMelQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mocsharp mocsharp removed the request for review from dbericat March 24, 2025 23:14
@mocsharp mocsharp merged commit 867bded into main Mar 24, 2025
13 checks passed
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.2 🎉

The release is available on:

Copy link
Member

@dbericat dbericat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants