Skip to content

Conversation

@afarber
Copy link
Contributor

@afarber afarber commented Aug 28, 2025

Issue

Fix the #7226 by

  • Rename *.cjs scripts to *.js and convert them to ESM
  • Convert var to let/const
  • Add 1 line comments to each script

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@afarber afarber changed the title Convert from CommonJS to ESM Convert scripts from CommonJS to modern ESM format Aug 29, 2025
@afarber afarber marked this pull request as ready for review August 29, 2025 07:01
@afarber
Copy link
Contributor Author

afarber commented Sep 1, 2025

Hi @DennisOSRM you asked me to create node.js related issues to follow up and clean up.

So I have created 4 issues last week and this PR fixes the first of them:

Please review

@afarber
Copy link
Contributor Author

afarber commented Sep 3, 2025

Hi @DennisOSRM please consider merging to master, then I can implement the other 3 PRs (they are based on this one)

@DennisOSRM DennisOSRM merged commit d810121 into Project-OSRM:master Sep 3, 2025
21 checks passed
@afarber afarber deleted the 7226-convert-to-esm branch September 3, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants