Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Unreleased
- Changes from 6.0.0
- Misc:
- CHANGED: Replace std::is_trivial with std::is_trivially_default_constructible && std::is_trivially_copyable [#7245](https://github.com/Project-OSRM/osrm-backend/issues/7245)
- ADDED: Add husky pre-commit hook for compiling and linting staged JS files [#7228](https://github.com/Project-OSRM/osrm-backend/issues/7228)
- CHANGED: Standardize linting configuration with ESM-specific rules [#7229](https://github.com/Project-OSRM/osrm-backend/issues/7229)
- CHANGED: Convert scripts from CommonJS to modern ESM format [#7230](https://github.com/Project-OSRM/osrm-backend/pull/7230)
Expand Down
22 changes: 16 additions & 6 deletions include/util/coordinate.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -68,19 +68,29 @@ using FloatLongitude = Alias<double, tag::longitude>;
// range checks on these (toFixed/toFloat, etc)
using UnsafeFloatLatitude = Alias<double, tag::unsafelatitude>;
using UnsafeFloatLongitude = Alias<double, tag::unsafelongitude>;
static_assert(std::is_standard_layout<FixedLatitude>() && std::is_trivial<FixedLatitude>(),
static_assert(std::is_standard_layout<FixedLatitude>() &&
std::is_trivially_default_constructible<FixedLatitude>() &&
std::is_trivially_copyable<FixedLatitude>(),
"FixedLatitude is not a valid alias");
static_assert(std::is_standard_layout<FixedLongitude>() && std::is_trivial<FixedLongitude>(),
static_assert(std::is_standard_layout<FixedLongitude>() &&
std::is_trivially_default_constructible<FixedLongitude>() &&
std::is_trivially_copyable<FixedLongitude>(),
"FixedLongitude is not a valid alias");
static_assert(std::is_standard_layout<FloatLatitude>() && std::is_trivial<FloatLatitude>(),
static_assert(std::is_standard_layout<FloatLatitude>() &&
std::is_trivially_default_constructible<FloatLatitude>() &&
std::is_trivially_copyable<FloatLatitude>(),
"FloatLatitude is not a valid alias");
static_assert(std::is_standard_layout<FloatLongitude>() && std::is_trivial<FloatLongitude>(),
static_assert(std::is_standard_layout<FloatLongitude>() &&
std::is_trivially_default_constructible<FloatLongitude>() &&
std::is_trivially_copyable<FloatLongitude>(),
"FloatLongitude is not a valid alias");
static_assert(std::is_standard_layout<UnsafeFloatLatitude>() &&
std::is_trivial<UnsafeFloatLatitude>(),
std::is_trivially_default_constructible<UnsafeFloatLatitude>() &&
std::is_trivially_copyable<UnsafeFloatLatitude>(),
"UnsafeFloatLatitude is not a valid alias");
static_assert(std::is_standard_layout<UnsafeFloatLongitude>() &&
std::is_trivial<UnsafeFloatLongitude>(),
std::is_trivially_default_constructible<UnsafeFloatLongitude>() &&
std::is_trivially_copyable<UnsafeFloatLongitude>(),
"UnsafeFloatLongitude is not a valid alias");

/**
Expand Down
8 changes: 6 additions & 2 deletions include/util/typedefs.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,15 @@ struct turn_penalty
using OSMNodeID = osrm::Alias<std::uint64_t, tag::osm_node_id>;
// clang-tidy fires `bugprone-throw-keyword-missing` here for unknown reason
// NOLINTNEXTLINE(bugprone-throw-keyword-missing)
static_assert(std::is_standard_layout<OSMNodeID>() && std::is_trivial<OSMNodeID>(),
static_assert(std::is_standard_layout<OSMNodeID>() &&
std::is_trivially_default_constructible<OSMNodeID>() &&
std::is_trivially_copyable<OSMNodeID>(),
"OSMNodeID is not a valid alias");
using OSMWayID = osrm::Alias<std::uint64_t, tag::osm_way_id>;
// NOLINTNEXTLINE(bugprone-throw-keyword-missing)
static_assert(std::is_standard_layout<OSMWayID>() && std::is_trivial<OSMWayID>(),
static_assert(std::is_standard_layout<OSMWayID>() &&
std::is_trivially_default_constructible<OSMWayID>() &&
std::is_trivially_copyable<OSMWayID>(),
"OSMWayID is not a valid alias");

using DuplicatedNodeID = std::uint64_t;
Expand Down
Loading