Make pagination consistent (use next cursor everywhere)#27
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Original prompt from Ryan |
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize pagination to use
nextcursors across CLI + SDKSummary
tokens trendingandtokens topto use--next <cursor>instead of--cursor <cursor>(to match all other paginated commands). Internally still sends the server query param ascursor.TokensAPI.trending()/TokensAPI.top()options to accept{ next?: string }(instead of{ cursor?: string }) and mapnext → cursorin the request params.PaginatedResponse<T>type since SDK response shapes vary by endpoint key (nfts,listings,offers, etc.).--nexteverywhere and documented that search commands don’t expose cursor-based pagination.@opensea/climinor version0.2.1 → 0.3.0.next → cursormapping.Review & Testing Checklist for Human
opensea tokens trending --limit 5 --next "<cursor>"fetches the next page (and that the outgoing query param is stillcursor).client.tokens.trending({ next: "<cursor>" })/top({ next: "<cursor>" })correctly advances pages.--cursor/cursoras the public pagination option (especially around tokens + pagination docs).Notes