Feature/mem optimization v2 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The structs were already being allocated to the heap, but as a struct, the object pool wasn't working correctly, so it was still allocating to the heap. By changing it to a class, it fixes this issue.
|
did some more work and now the library is extremely performant. Final resultsAllocation Rate: 6.53 MiB :D I just need to fix a memory leak related to the |
|
Is this ready or still a draft? |
|
@michaelsakharov I fixed the memory leak issue with TextLayoutSettings :) it seems it was an issue with using stack to pool the objects, so i changed it to a list and explicit index. seems to work very well now and the GC pressure is even lower in markdown mode. this PR is ready for review! |
Exanite
reviewed
Sep 27, 2025
| } | ||
|
|
||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to reduce the number of allocations in Scribe to increase the performance. I am creating this pull request so others can look at the code and help with the optimization. Outcome is a 99% reduction in the allocation rate and 99% decrease in the number of GC events
Using Markdown layout system
Before
Allocation Rate: 864 MiB
GC Count: ~71/frame
After
Allocation Rate: 6.53 MiB
Allocations/Frame: ~38/frame
GC Count: <1/second
The markdown demo is by far the most demanding on the system. For the other demos, just rendering text is now extremely fast
Before
After