Skip to content

Charging Part 2#331

Draft
irvingywang wants to merge 3 commits intomasterfrom
irving/charging-cleanup
Draft

Charging Part 2#331
irvingywang wants to merge 3 commits intomasterfrom
irving/charging-cleanup

Conversation

@irvingywang
Copy link
Copy Markdown
Member

No description provided.

@irvingywang
Copy link
Copy Markdown
Member Author

@LelsersLasers

"msg_priority": 5,
"msg_priority": 4,
"msg_period": 1000
},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temps? Module info? Discharge arrays?
The problem is that the low/high/sum of pack/module stats is not stable in time, so we should send reasonable period snap shots of those.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah cells only for now

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a bool to this that is is being balanced or smth like that?`

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

"type": "bool"
},
{
"sig_name": "balance_enable",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link the daqapp open pr that it should change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants