Allow stageHeight and stageWidth to be in any kind of CSS units#34
Open
gbagan wants to merge 3 commits intoPuruVJ:mainfrom
Open
Allow stageHeight and stageWidth to be in any kind of CSS units#34gbagan wants to merge 3 commits intoPuruVJ:mainfrom
gbagan wants to merge 3 commits intoPuruVJ:mainfrom
Conversation
🦋 Changeset detectedLatest commit: ae1defa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for this great library.
I propose this PR to fix the issue #1
It allows
stageHeightandstateWidthto be in any kind of CSS units.The type changes from
numbertostring | number.calc()is allowed. For exemple{stageWidth: "calc(100vh - 200px)" }.Unless I'm wrong, this doesn't introduce breaking changes.