Skip to content

[WIP]: Unindented comments get cut off #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[WIP]: Unindented comments get cut off #1905

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef172ef
Add failing test for unindenred comment
anirudnits Mar 1, 2022
41c119e
Merge branch 'main' into issue/1899
DanielNoord Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tests/unit/test_isort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5562,6 +5562,21 @@ def seekable(self):
assert identified_imports == [":1 import m2", ":2 import m1"]


def test_unindented_comments_issue_1899():
"""Ensure unindented comments in indented blocks are handled correctly"""

test_input = """
import sys

if True:
# this comment will get cut off
import os

"""

assert isort.code(test_input) == test_input


def test_split_on_trailing_comma() -> None:
test_input = "from lib import (a, b, c,)"
expected_output = """from lib import (
Expand Down
Loading