extend pyo3-ffi-check to check functions#5965
Open
davidhewitt wants to merge 5 commits intoPyO3:mainfrom
Open
Conversation
Contributor
|
Let me know if you want some support with this. I'd really like to extend the FFI checking to abi3 and abi3t as well. |
davidhewitt
added
the
CI-no-fail-fast
Member
Author
|
Help is welcome, yes. Fixing all the definitions for all versions looks like it might take a bit of work, worse I am running into variants of #4882 when trying to try to test for different versions. Maybe I will first try to get #5862 merged first which will simplify the build process and make it easier to probe. Feel free to push to this PR in the meanwhile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to add more correctness to
pyo3-ffiby validating that external function symbols actually exist and have the same number of arguments. This is quite a step forward, wherepyo3-ffi-checkcurrently doesn't check anything for functions.