fix: Properly sample Array columns with nested inner types#244
Draft
fix: Properly sample Array columns with nested inner types#244
Conversation
…Struct) Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix sampling issue for Array(List(...), ...) columns
Fix sampling for Array columns with nested inner types (List, Array, Struct)
Dec 17, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
===========================================
- Coverage 100.00% 99.74% -0.26%
===========================================
Files 53 53
Lines 3066 3089 +23
===========================================
+ Hits 3066 3081 +15
- Misses 0 8 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sampling failed for
Array(List(...), ...)and other nested array types because_sample_uncheckedassumedinner.sample()returned flat scalars suitable forreshape(). When the inner type is a complex nested type, it returns structured objects that cannot be reshaped.Changes
dataframely/columns/array.py: Added type checking in_sample_uncheckedto detect nested inner types (List,Array,Struct) and construct the array structure manually via a recursive helper function. Scalar inner types continue using the optimizedreshape()path.tests/columns/test_sample.py: Added parametrized tests coveringArray(List(...)),Array(Array(...)), andArray(Struct(...))with various shapes and sample counts.Example
Original prompt
Array(List(...), ...)#243💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.