test: Emulation test for modifier resolver#1293
Draft
hkengo-qtnm wants to merge 13 commits intomainfrom
Draft
Conversation
first modifier compiler, with extensions imported modifier_compiler now directly compiles cfgs minor reference to tket repository with new extensions integration test for modifier_compiler minor
some refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rough draft PR proposes one example idea to test the compiler pass for modifiers. This PR doesn't need to be merged soon.
It is very difficult to test implementation of compiler pass for modifiers. Especially because the implementation of modifier resolver in tket::modifier::modifier_resolver::tket_op_modify is huge, and also the output Hugr can easily become quite huge depending on the number of control qubits. We should have some testing method for them. Now that since
qis-compileris merged to TKET2 repo, it might be possible to run tests in TKET, however, I believe writing circuits in guppy syntax and check them using numpy(or sympy) in python is probably the simplest approach.I have implemented two small examples to check the semantics of control and dagger modifiers. This is not enough, but should be better than nothing.