WIP: Extend dataflow analysis to handle reachability#1672
Draft
WIP: Extend dataflow analysis to handle reachability#1672
Conversation
* DFContext reinstate fn hugr(), drop AsRef requirement (fixes StackOverflow) * test_tail_loop_iterates_twice: use tail_loop_builder_exts, fix from #1332(?) * Fix only-one-DataflowContext asserts using Arc::ptr_eq
…text interprets load_constant
Collaborator
|
Hey there and thank you for opening this pull request! 👋 We require pull request titles to follow the Conventional Commits specification Your title should look like this. The scope field is optional. If the PR includes a breaking change, mark it with an exclamation mark: and include a "BREAKING CHANGE:" footer in the body of the pull request. Details: |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Forwards analysis only, but parametrized over the abstract domain, hence intended to support various applications including constant folding and potentially devirtualization, intergraph-edge-insertion, etc. Much complexity is to do with "native" (irrespective of the underlying domain) treatment of Sum types necessary for proper understanding of control flow (e.g. conditionals, loops, CFGs). Generalization of reachability left to #1672 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
panicreturns Bottom everywherepanicor TailLoop's whose result isn't used - can containing DFG terminate? Suggests "DFG Output-node-inputs are not propagated to DFG-outputs if ANY node in the DFG has a Bottom output"