Draft
Conversation
|
Hi @pauljohanneskraft, any news about this? |
Collaborator
Author
|
Hey @andrefmsilva ! I'm still working on some of these changes and think of some additional features (or if there is going to be some anyways), but I would like to have that finished, since these changes will require a major version update. Do you already have any remarks regarding the current changes in this branch? |
|
Hi, i will update my app to use this branch and run some tests to see if i find some problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog:
Unresolved Issues:
any Router<RouteType>is used in a transition, it requires a.asPresentableto "convert" it to make it conform toPresentable, which it already does. It would work fine for iOS 16+, but it makes no sense to restrict this library in this way and it makes it harder for beginners to use transitions with existential routers in general.