Skip to content

Conversation

bms63
Copy link
Contributor

@bms63 bms63 commented Sep 21, 2025

  • Removed old files from Pilot 3 ADRG ( a lot of files 🗑️ )
  • Appendix 2: Inserted Pilot 3 QC Findings from Wiki, Pilot 5 findings are minor and will be done later
  • Appendix 3: Inserted text from wiki comparing 1.1 and 1.0 standards
  • Conformance Summaries: comparison of two methods explanations and findings
  • Cosmetic Updates
  • Code updated to use version = 5 for xpt write out.

@bms63 bms63 changed the title 111 update adrg to mention the json standard version dataset json v110 from cdisc Closes #111 update adrg to mention the json standard version dataset json v110 from cdisc Sep 21, 2025
Copy link

github-actions bot commented Sep 21, 2025

Dataset QC Check Complete!

Date: 2025-09-26
Run by: bms63
Git Ref: refs/pull/123/merge
BASE: Pilot 5 Datasets
COMPARE: Pilot 3 Datasets

✅ Dataset: adadas

No issues were found!
✅ Dataset: adae

No issues were found!
✅ Dataset: adlbc

No issues were found!
✅ Dataset: adsl

No issues were found!
✅ Dataset: adtte

No issues were found!

Copy link

github-actions bot commented Sep 21, 2025

TLF QC Check Complete!

Date: 2025-09-26
Run by: bms63
Git Ref: refs/pull/123/merge
BASE: Pilot 5 Datasets
COMPARE: Pilot 3 Datasets

✅ Dataset: tlf-demographic-pilot5.out

old[36:40] vs new[36:40]
  "—————————————————————————————————————————————————————————————————————————————————————————————————"
  ""
  "Program: tlf-demographic.r "
- "2025-09-24 23:21:51.570937"
+ "2024-04-18 20:17:25"
  ""
✅ TLF: tlf-kmplot-pilot5.pdf - Score: 85

[1] "1. The second image has a visible grid pattern in the background while the first image has a plain white background. 2. The font size and style of the title appears slightly different - the second image has a bolder, more prominent title. 3. The legend positioning is slightly different - in the first image it appears more to the right, while in the second it's positioned more centrally. 4. The axis labels and tick marks appear to have slightly different formatting and spacing. 5. The confidence intervals (shaded areas) around the survival curves appear to have slightly different transparency/opacity levels. 6. The table at the bottom has minor formatting differences in terms of spacing and alignment. 7. The program information at the bottom shows different timestamps and version information. 8. The overall plot dimensions and aspect ratio appear slightly different between the two images."

✅ TLF: tlf-efficacy-pilot5.rtf - Score: 98

[1] "After careful examination of both images, I found these are essentially identical ANCOVA statistical tables showing 'Change from Baseline at Week 26'. Both tables contain the same data structure, values, and layout including: same title, identical column headers (Treatment groups, N values, Mean (SE) values for different doses), same row labels (Estimated High Dose vs Placebo, Estimated High Dose vs Medium), identical statistical values throughout all cells, same footnote text about ANCOVA model and treatment/baseline value covariates, and same overall formatting and spacing. The only potential differences might be extremely minor variations in image quality, compression, or pixel-level artifacts that don't affect the substantive content."

✅ TLF: tlf-primary-pilot5.rtf - Score: 100

[1] "After careful examination of both images, I found no detectable differences between them. Both images appear to be identical medical/clinical documents showing Patient CEH0609/Page 1 of 2 Precision Dosing form. The documents contain the same tabular data with identical values across all rows and columns, including: matching patient identifier (CEH0609), identical page numbering (1 of 2), same header text about 'Primary Diagnosis Analysis ADHD - using Ranger plus decision as listed at 1557', identical table structure with same row labels (MetaGIS, Normal Range, Weight etc.), matching numerical values throughout all data cells, identical formatting and layout, same footer text and disclaimers, and matching document structure with two similar table sections. The images appear to be exact duplicates with no visible variations in content, formatting, positioning, or quality."

@bms63
Copy link
Contributor Author

bms63 commented Sep 26, 2025

Hi all!! Got some big updates for ADRG - if any one has time to review I would be much appreciated by EOD. If not, I will just merge in and keep trying to push forward.

Can always update ADRG later if issues are identified.

@bms63 bms63 requested a review from rpodcast September 26, 2025 17:39
@rpodcast rpodcast merged commit 830c581 into main Sep 26, 2025
6 checks passed
@rpodcast rpodcast deleted the 111-update-adrg-to-mention-the-json-standard-version-dataset-json-v110-from-cdisc branch September 26, 2025 17:46
@github-project-automation github-project-automation bot moved this from Todo to Done in Pilot 5: datasetjson Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Update ADRG to mention the JSON standard version (Dataset-JSON v1.1.0 from CDISC)

2 participants