Openshift Administrator package

[r2dedios]

Current skills:

• Cluster Inventory
• Cluster Creator

[ikrispin]

Besides some minor things looks good!

BTW - @r2dedios you can push an empty commit to trigger the newly added Gemini CR.

Edit: seems to be problematic in the case of fork PRs.

[r2dedios]

Validation errors were solved. Ready to be merged

[github-actions]

Gemini Code Review

1. Summary

This PR significantly expands the ocp-admin pack, adding support for cluster creation and inventory management via Red Hat Assisted Installer and OCM. It introduces new MCP server configurations (openshift-self-managed, openshift-ocm-managed), updates CLAUDE.md and README.md with new intents and instructions, and adds a comprehensive set of 13 new documentation files for OpenShift administration.

2. Project Rules Compliance

• ❌ Missing YAML Frontmatter in Documentation: The project rules explicitly state that "All docs include YAML frontmatter" with specific fields (title, category, sources, tags, semantic_keywords, use_cases, related_docs, last_updated). None of the new documentation files in ocp-admin/docs/ contain this frontmatter.
• ❌ Source Attribution: The rules require official sources to be documented in docs/SOURCES.md and referenced in the YAML frontmatter. The PR adds references at the bottom of the markdown files instead.
• ⚠️ Build Reminder: Since .mcp.json was modified, please remember to run make validate to ensure everything passes the automated checks.

3. Code Quality Issues

• Direct MCP Tool Calls in Docs: In ocp-admin/docs/certificate-rotation.md and ocp-admin/docs/idp.md, there are examples of direct MCP tool invocations (e.g., MCP Tool: resources_get). While this is just documentation, it contradicts the core principle "Never call MCP tools directly; always invoke skills" and might confuse the AI agent reading these docs into attempting direct tool calls. Consider replacing these with the equivalent skill invocations or explicitly marking them as internal/under-the-hood references.
• Plugin Name Mismatch: In ocp-admin/.claude-plugin/plugin.json, the name was changed from ocp-admin to openshift-administration. While not strictly a violation, it's generally best practice to keep the plugin name consistent with the directory name (ocp-admin) to avoid confusion during installation (the README still says claude plugin install ocp-admin).

4. Suggestions

• Add Required Frontmatter: Please add the following YAML block to the top of all .md files in the docs/ directory, filling in the appropriate metadata for each file:

  ---
  title: Document Title
  category: openshift
  sources:
    - title: Official Red Hat Doc Title
      url: https://docs.redhat.com/...
      date_accessed: 2024-03-XX
  tags: [keyword1, keyword2]
  semantic_keywords: [phrases for AI discovery]
  use_cases: [task_ids]
  related_docs: [cross-references]
  last_updated: 2024-03-XX
  ---

• Documentation Indexing: Once the YAML frontmatter is added to the docs, ensure you run the semantic indexing script (python docs/.ai-index/generate-index.py if available for this pack) to optimize token usage as per the rh-sre reference pattern.
• Plugin Name: Consider reverting the name field in plugin.json back to ocp-admin to match the directory and the installation instructions.

5. Verdict

REQUEST_CHANGES

The missing YAML frontmatter across all new documentation files is a blocking violation of the project's AI-optimized documentation standards. Please add the required frontmatter to all .md files in the docs/ directory.

---

Automated review by Gemini 3.1 Pro | Rules: CLAUDE.md, SKILL_DESIGN_PRINCIPLES.md

[dmartinol]

Code review

Found 3 issues:

1. New ocp-admin/docs/*.md files do not follow repository documentation standards — root CLAUDE.md requires YAML frontmatter on docs and source attribution via docs/SOURCES.md; this pack adds many markdown guides under ocp-admin/docs/ without that frontmatter, and there is no ocp-admin/docs/SOURCES.md (Documentation Standards, Official sources only). Example of docs as-added: ocp-admin/docs/networking.md#L1-L12.

2. cluster-creator tells users to use MCP tools directly for out-of-scope work, which contradicts the pack skill-first rule and repo architecture (Skills encapsulate tools; Never call MCP tools directly; ocp-admin/CLAUDE.md skill-first rule): ocp-admin/skills/cluster-creator/SKILL.md#L16-L19, L98-L101. Wording should route to the appropriate skill (or state that only the hosting agent may use MCP per pack rules), not "use openshift-administration MCP tools" as an end-user instruction.

3. Pack docs illustrate direct MCP tool calls (resources_get, resources_create, …), which conflicts with the same "never call MCP directly" guidance and can steer agents wrong (Key Pattern): ocp-admin/docs/certificate-rotation.md#L62-L74, ocp-admin/docs/idp.md#L73-L76.

Generated with Claude Code