pkg: replace header guards with #pragma once #21701
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N11cc00
requested review from
leandrolanzieri,
basilfx,
jue89,
aabadie,
jia200x,
bergzand,
kaspar030,
miri64 and
PeterKietzmann
as code owners
github-actions
bot
added
Area: network
N11cc00
changed the title
8 tasks
crasbe
added
Type: cleanup
N11cc00
force-pushed
the
fix-pkg-headers
branch
3 times, most recently
from
52167ef to
512a3fa
Compare
|
I did not go through these files yet, but maybe you can run the latest revision of the script on this PR too? |
N11cc00
force-pushed
the
fix-pkg-headers
branch
from
512a3fa to
7b57ce3
Compare
crasbe
reviewed
Sep 8, 2025
crasbe
reviewed
Sep 9, 2025
There was a problem hiding this comment.
/*
* Generated by ./update_mk.sh, don't modify directly.
* Default CONFIG_ parameters from the SDK package.
*/
This file should probably not be modified directly.
| #ifdef __cplusplus | ||
| } | ||
| #endif | ||
|
|
| #endif | ||
|
|
||
| #endif /* LUA_BUILTIN_H */ | ||
|
|
| extern "C" | ||
| } | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Unrelated: it was good that this file got migrated, because the closing header guard was before the _cplusplus thingy. That would've caused weird issues when using C++...
| #endif | ||
|
|
||
| #endif /* OPENDSME_OPENDSME_H */ | ||
|
|
| #ifdef __cplusplus | ||
| } | ||
| #endif | ||
|
|
|
I reviewed the rest of the files and found no further issues. So once the remaining review comments are addressed, we can get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This is part of a greater effort to replace all header guards in RIOT with
#pragma once. This PR only affects all headers underpkg/, excluding those that have a path that contains/vendor/.It should now remove double empty lines around the
#ifndefblock.Issues/PRs references
Tracking issue #21335