Skip to content

Conversation

@DongyunRobotis
Copy link
Member

Fixed an issue where the task_index was being merged based on the first episode when merging episodes in the .parquet data.

@DongyunRobotis DongyunRobotis self-assigned this Nov 26, 2025
Copilot AI review requested due to automatic review settings November 26, 2025 10:27
@DongyunRobotis DongyunRobotis added the bug Something isn't working label Nov 26, 2025
@github-project-automation github-project-automation bot moved this to 🌱 Todo in Platform Nov 26, 2025
@DongyunRobotis DongyunRobotis moved this from 🌱 Todo to 📝 Pull Request in Platform Nov 26, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @DongyunRobotis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the data merging process, specifically concerning the task_index in .parquet files. Previously, when combining multiple datasets, the task_index was incorrectly handled, leading to potential data integrity issues. The changes introduce a new, intelligent mapping system to ensure that task_index values are consistently and uniquely assigned across all merged episodes, thereby resolving the merging errors and improving data reliability.

Highlights

  • Corrected task_index Merging Logic: Implemented a new mechanism to correctly merge task_index values when combining multiple .parquet datasets, resolving an issue where indexing was based on the first episode and ensuring consistent task identifiers across merged data.
  • Introduced Unified Task Mapping: A new private method, _build_merged_task_mapping, was added to generate a comprehensive mapping for task_index values across all datasets being merged, which is then applied during the data copying and updating process.
  • Version Bumps Across Packages: The version number for physical_ai_interfaces, physical_ai_manager, physical_ai_server, physical_ai_tools, and rosbag_recorder packages has been updated to 0.7.1 to reflect this fix and other minor updates.
  • Added Isaac-GR00T Subproject: The Isaac-GR00T repository has been included as a new subproject.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an important bug in dataset merging where task_index values could collide. The introduction of _build_merged_task_mapping is a good approach to create a unified mapping before processing the files. My review includes a suggestion for a more efficient implementation using pandas, a type hint improvement for better code clarity, and a high-severity comment about an incomplete fix that could lead to inconsistent metadata. Overall, the core logic of the fix is sound, but requires a bit more work to be complete and robust.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the dataset merging logic where task_index values were being incorrectly merged based on the first episode's task index. The fix introduces a new task mapping system that correctly remaps task indices across merged datasets by task name, ensuring consistency when multiple datasets with potentially overlapping task indices are combined.

Key changes:

  • Added _build_merged_task_mapping() method to create a mapping between old and new task indices based on task names
  • Updated _copy_parquet_and_update_indices_for_merge() to apply the task index mapping when processing parquet files
  • Bumped version to 0.7.1 across all packages

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
physical_ai_server/physical_ai_server/data_processing/data_editor.py Implements the core fix by building task index mappings and applying them during parquet merge operations
rosbag_recorder/package.xml Version bump to 0.7.1
rosbag_recorder/CHANGELOG.rst Added changelog entry for 0.7.1
physical_ai_tools/package.xml Version bump to 0.7.1
physical_ai_tools/CHANGELOG.rst Added changelog entry describing the task_index merge fix
physical_ai_server/setup.py Version bump to 0.7.1
physical_ai_server/package.xml Version bump to 0.7.1
physical_ai_server/CHANGELOG.rst Added changelog entry describing the task_index merge fix
physical_ai_manager/package.json Version bump to 0.7.1
physical_ai_manager/CHANGELOG.rst Added changelog entry for 0.7.1
physical_ai_interfaces/package.xml Version bump to 0.7.1
physical_ai_interfaces/CHANGELOG.rst Added changelog entry for 0.7.1
Isaac-GR00T Added subproject commit reference
Files not reviewed (1)
  • physical_ai_manager/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.

Files not reviewed (1)
  • physical_ai_manager/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Dongyun Kim <[email protected]>
Copilot finished reviewing on behalf of DongyunRobotis November 28, 2025 01:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • physical_ai_manager/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Dongyun Kim <[email protected]>
Copy link
Member

@ola31 ola31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Copy link
Member

@Seongoo Seongoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ola31 ola31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DongyunRobotis Please update versions to 0.7.2 🙏

@DongyunRobotis DongyunRobotis requested a review from ola31 November 30, 2025 22:53
@DongyunRobotis DongyunRobotis merged commit 917097f into main Dec 1, 2025
10 checks passed
@DongyunRobotis DongyunRobotis deleted the feature-fix-merge-error branch December 1, 2025 02:36
@github-project-automation github-project-automation bot moved this from 📝 Pull Request to 🚩Done in Platform Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: 🚩Done

Development

Successfully merging this pull request may close these issues.

4 participants