Skip to content

Conversation

@GyuH13
Copy link
Member

@GyuH13 GyuH13 commented Jun 22, 2025

No description provided.

GyuH13 added 4 commits June 23, 2025 08:13
Signed-off-by: Hyungyu Kim <[email protected]>
Signed-off-by: Hyungyu Kim <[email protected]>
Signed-off-by: Hyungyu Kim <[email protected]>
Signed-off-by: Hyungyu Kim <[email protected]>
Copilot AI review requested due to automatic review settings June 22, 2025 23:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses buildfarm errors by updating package versions from 1.3.2 to 1.3.3 and making minor dependency adjustments. Key changes include:

  • Incrementing version numbers in setup.py, package.xml, and CHANGELOG.rst for multiple packages.
  • Adding new dependencies (libopencv-dev, tf2, tf2_geometry_msgs) in turtlebot3_panorama/package.xml.
  • Removing diagnostic message outputs in turtlebot3_panorama/CMakeLists.txt.

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
turtlebot3_yolo_object_detection/setup.py Version bump from 1.3.2 to 1.3.3
turtlebot3_yolo_object_detection/package.xml Version bump from 1.3.2 to 1.3.3
turtlebot3_yolo_object_detection/CHANGELOG.rst Updated changelog for version 1.3.3
turtlebot3_panorama/package.xml Version bump with additional dependency declarations
turtlebot3_panorama/CMakeLists.txt Removed diagnostic message outputs
turtlebot3_panorama/CHANGELOG.rst Updated changelog for version 1.3.3
turtlebot3_follower/package.xml Version bump from 1.3.2 to 1.3.3
turtlebot3_follower/CHANGELOG.rst Updated changelog for version 1.3.3
turtlebot3_automatic_parking_vision/setup.py Version bump from 1.3.2 to 1.3.3
turtlebot3_automatic_parking_vision/package.xml Version bump from 1.3.2 to 1.3.3
turtlebot3_automatic_parking_vision/CHANGELOG.rst Updated changelog for version 1.3.3
turtlebot3_automatic_parking/setup.py Version bump from 1.3.2 to 1.3.3
turtlebot3_automatic_parking/package.xml Version bump from 1.3.2 to 1.3.3
turtlebot3_automatic_parking/CHANGELOG.rst Updated changelog for version 1.3.3
turtlebot3_aruco_tracker/setup.py Version bump from 1.3.2 to 1.3.3
turtlebot3_aruco_tracker/package.xml Version bump from 1.3.2 to 1.3.3
turtlebot3_aruco_tracker/CHANGELOG.rst Updated changelog for version 1.3.3
turtlebot3_applications/package.xml Version bump from 1.3.2 to 1.3.3
turtlebot3_applications/CHANGELOG.rst Updated changelog for version 1.3.3 with cross-reference fix
Comments suppressed due to low confidence (2)

turtlebot3_panorama/CMakeLists.txt:16

  • [nitpick] The removal of diagnostic messages reduces console output during configuration; if these messages were helpful for debugging the ROS2 environment, consider replacing them with a configurable logging mechanism.
  add_definitions(-DROS2_HUMBLE)

turtlebot3_applications/CHANGELOG.rst:7

  • The changelog entry in this file cross-references a fix for turtlebot3_panorama. Please verify that this reference is intentional and, if so, consider adding a brief explanation to clarify the relation.
* Fix package.xml in turtlebot3_panorama

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @GyuH13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses buildfarm errors by incrementing the version number for several turtlebot3_* application packages to 1.3.3. The core fix involves updating the package.xml for turtlebot3_panorama to include necessary dependencies, which was likely causing build failures. Additionally, minor cleanup was performed in the CMakeLists.txt of the turtlebot3_panorama package.

Highlights

  • Version Bumps: All turtlebot3_* application packages have been updated to version 1.3.3 in their package.xml and setup.py files (where applicable). This includes turtlebot3_applications, turtlebot3_aruco_tracker, turtlebot3_automatic_parking, turtlebot3_automatic_parking_vision, turtlebot3_follower, turtlebot3_panorama, and turtlebot3_yolo_object_detection.
  • Dependency Fix for turtlebot3_panorama: The turtlebot3_panorama/package.xml file has been updated to include new dependencies: libopencv-dev, tf2, and tf2_geometry_msgs. This change is specifically noted in the changelog entries for turtlebot3_applications and turtlebot3_panorama.
  • CMake Cleanup: Debug message() calls that were printing 'Humble' or 'Latest' have been removed from turtlebot3_panorama/CMakeLists.txt.
  • Changelog Updates: The CHANGELOG.rst files for all affected packages have been updated to reflect the 1.3.3 release. The changelogs for turtlebot3_applications and turtlebot3_panorama explicitly mention the package.xml fix for turtlebot3_panorama.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a build farm error by adding missing dependencies to the turtlebot3_panorama package and updating package versions. It also removes debugging messages from a CMakeLists.txt file. The changes resolve the dependency issue.

@GyuH13 GyuH13 requested a review from robotpilot June 22, 2025 23:52
Copy link
Member

@robotpilot robotpilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robotpilot robotpilot self-assigned this Jun 23, 2025
@robotpilot robotpilot added the bug Something isn't working label Jun 23, 2025
@github-project-automation github-project-automation bot moved this to 🌱 Todo in Platform Jun 23, 2025
@robotpilot robotpilot moved this from 🌱 Todo to 📝 Pull Request in Platform Jun 23, 2025
@robotpilot robotpilot merged commit 2f03107 into main Jun 23, 2025
10 checks passed
@robotpilot robotpilot deleted the feature-buildfarm-error-fix branch June 23, 2025 01:56
@github-project-automation github-project-automation bot moved this from 📝 Pull Request to 🚩Done in Platform Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants