-
Notifications
You must be signed in to change notification settings - Fork 141
Bump 2.4.0 #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump 2.4.0 #54
Conversation
Signed-off-by: Hyungyu Kim <[email protected]>
Signed-off-by: Hyungyu Kim <[email protected]>
Signed-off-by: Hyungyu Kim <[email protected]>
Add Goal.srv for machine learning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (4)
- CHANGELOG.rst: Language not supported
- CMakeLists.txt: Language not supported
- package.xml: Language not supported
- srv/Goal.srv: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @robotpilot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request bumps the version of the turtlebot3_msgs package from 2.3.0 to 2.4.0. It includes an update to Goal.srv for turtlebot3_machine_learning, and updates the package.xml and CHANGELOG.rst files to reflect the new version number and associated changes. A new service definition file, Goal.srv, is added, defining the structure for goal-related data with pose_x, pose_y, and success fields.
Highlights
- Version Bump: The package version is incremented from 2.3.0 to 2.4.0.
- Service Definition: A new service definition
Goal.srvis added, which includes fields forpose_x,pose_y, andsuccess. - Changelog Update: The
CHANGELOG.rstfile is updated to include the new version and a description of the changes.
Changelog
Click here to see the changelog
- CHANGELOG.rst
- Added a new entry for version 2.4.0.
- Indicated that
Goal.srvwas updated forturtlebot3_machine_learning. - Added ChanHyeong Lee as a contributor.
- CMakeLists.txt
- Added
srv/Goal.srvto the list of service files to be processed.
- Added
- package.xml
- Updated the package version to 2.4.0.
- Updated the website URL.
- Re-added Junyeong Jeong to the list of authors.
- srv/Goal.srv
- Created a new service definition file.
- Defined the request as empty and the response to include
float32 pose_x,float32 pose_y, andbool success.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A service defined,
Goals set, success aligned,
Robots learn and roam.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the version to 2.4.0 and adds a new Goal.srv service. The changes are straightforward and well-documented in the CHANGELOG. No major issues were found. Good job on the clear and concise commit messages!
Merge Readiness
The code changes are ready to be merged. I have no critical or high severity issues. However, please have other reviewers approve this code before merging. I am unable to approve the pull request.
| * Updated Goal.srv for turtlebot3_machine_learning | ||
| * Contributors: ChanHyeong Lee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a more descriptive summary of the changes made to Goal.srv in the changelog entry. For example, instead of just "Updated Goal.srv for turtlebot3_machine_learning", you could write something like "Added a new Goal.srv service for specifying target poses in the context of turtlebot3_machine_learning, including pose_x, pose_y, and success fields."
* Added a new Goal.srv service for specifying target poses in the context of turtlebot3_machine_learning, including pose_x, pose_y, and success fields.
No description provided.