[DRAFT] Third party deps install for hipDNN #1714
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelReeder
force-pushed
the
users/sareeder/third-party-deps-install
branch
from
104d17d to
b9eb6b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
hipDNN needs spdlog, flatbuffers, nlohmann json, and fmt as runtime deps for its installed header-only libs to be easily consumed.
Technical Details
Calls the
therock_provide_artifacton hipDNN's third party runtime deps when hipDNN is enabled.#1689 is a prerequisite for this PR.
Test Plan
Manual testing so far, but any recommendations are welcome.
Test Result
Runtime deps are installed if hipDNN is enabled. Consumers can compile with the installed hipDNN SDK and FE.
Submission Checklist