[OMPIRBuilder] NFC: Remove unused functions #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes some internal functions from the OMPIRBuilder that are not used and do not exist upstream. They seem to have been left behind after some merge or improvements to reductions support made them redundant.
skatrak
changed the title
searlmc1
pushed a commit
that referenced
this pull request
Apr 11, 2025
…ze (llvm#96422)" (#156)" This reverts commit e5cb8bd.
searlmc1
pushed a commit
that referenced
this pull request
May 9, 2025
…isZeroSize (llvm#96422)" (#156)"" (llvm#2065) This reverts commit c515ad9. This was relanded in llvm#1633, but we still need it reverted to maintain the the device function ABI.
searlmc1
pushed a commit
that referenced
this pull request
Aug 14, 2025
…ency on isZeroSize (llvm#96422)" (#156)"" (llvm#2065)" This reverts commit 4950ee0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes some internal functions from the OMPIRBuilder that are not used and do not exist upstream. They seem to have been left behind after some merge or improvements to reductions support made them redundant.