[MLIR][OpenMP] More robust support for target SPMD #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes `TargetOp::getInnermostCapturedOmpOp()` to avoid detecting as
captured by the top target construct other constructs nested inside of a loop.
This prevents the `omp.target` verifier from incorrectly flagging valid SPMD
loops, like in the following example:
```f90
subroutine foo(n)
implicit none
integer, intent(in) :: n
integer :: i, j
!$omp target teams distribute parallel do
do i=1,n
!$omp simd
do j=1,n
call bar()
enddo
enddo
end subroutine foo
```
ronlieb
approved these changes
Sep 23, 2024
dpalermo
approved these changes
Sep 24, 2024
|
Merged to get more coverage in tonight's build/testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes
TargetOp::getInnermostCapturedOmpOp()to avoid detecting as captured by the top target construct other constructs nested inside of a loop. This prevents theomp.targetverifier from incorrectly flagging valid SPMD loops, like in the following example:It's an improvement over the workaround implemented in #98, hopefully covering all cases.