Skip to content

Conversation

yixinghua121
Copy link
Contributor

@yixinghua121 yixinghua121 commented Mar 5, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

1.打开LOG_D后,编译不过去;
2.sdio 宏拼写错误;

你的解决方案是什么 (what is your solution)

查找结构体中变量所在位置

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/k230
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added Kernel PR has src relate code Component labels Mar 5, 2025
#define RT_SDIO_THREAD_PRIORITY 15
#define RT_MMCSD_STACK_SIZE 8192
#define RT_MMCSD_THREAD_PREORITY 22
#define RT_MMCSD_THREAD_PRIORITY 22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块为啥要改成这个?我搜了下没有这个定义

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单词拼写错了,顺手改的。。。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单词拼写错了,顺手改的。。。

那麻烦都改掉吧,https://github.com/search?q=repo%3ART-Thread%2Frt-thread+RT_MMCSD_THREAD_PREORITY+&type=code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经全部更改

@Rbb666 Rbb666 self-requested a review March 5, 2025 09:22
@CLAassistant
Copy link

CLAassistant commented Mar 12, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added BSP: NXP Code related with NXP BSP: STM32 BSP related with ST/STM32 BSP: Cvitek BSP related with cvitek BSP: Phytium BSP related with Phytium labels Mar 12, 2025
@Rbb666 Rbb666 changed the title fixed LOG bug 修复 MMCSD 宏拼写错误+内核开启LOG_D编译问题 Mar 12, 2025
@Rbb666 Rbb666 merged commit 983f021 into RT-Thread:master Mar 12, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: Cvitek BSP related with cvitek BSP: NXP Code related with NXP BSP: Phytium BSP related with Phytium BSP: STM32 BSP related with ST/STM32 BSP component: drivers/sdio component: drivers Component Kernel PR has src relate code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants