Skip to content

Conversation

@Ouxiaolong
Copy link
Contributor

@Ouxiaolong Ouxiaolong commented Aug 22, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

Add bsp ra6e2-ek.

请提供验证的bsp和config (provide the config and bsp)

bsp/renesas/ra6e2-ek

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

github-actions bot commented Aug 22, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_renesas

Reviewers: @kurisaW

Changed Files (Click to expand)
  • bsp/renesas/ra6e2-ek/.config
  • bsp/renesas/ra6e2-ek/.gitignore
  • bsp/renesas/ra6e2-ek/.ignore_format.yml
  • bsp/renesas/ra6e2-ek/.secure_azone
  • bsp/renesas/ra6e2-ek/.secure_xml
  • bsp/renesas/ra6e2-ek/.settings/standalone.prefs
  • bsp/renesas/ra6e2-ek/Kconfig
  • bsp/renesas/ra6e2-ek/README.md
  • bsp/renesas/ra6e2-ek/SConscript
  • bsp/renesas/ra6e2-ek/SConstruct
  • bsp/renesas/ra6e2-ek/board/Kconfig
  • bsp/renesas/ra6e2-ek/board/SConscript
  • bsp/renesas/ra6e2-ek/board/board.h
  • bsp/renesas/ra6e2-ek/board/ports/SConscript
  • bsp/renesas/ra6e2-ek/board/ports/gpio_cfg.h
  • bsp/renesas/ra6e2-ek/buildinfo.gpdsc
  • bsp/renesas/ra6e2-ek/configuration.xml
  • bsp/renesas/ra6e2-ek/docs/picture/download.png
  • bsp/renesas/ra6e2-ek/docs/picture/ek-ra6e2.png
  • bsp/renesas/ra6e2-ek/memory_regions.scat
  • bsp/renesas/ra6e2-ek/project.uvoptx
  • bsp/renesas/ra6e2-ek/project.uvprojx
  • bsp/renesas/ra6e2-ek/ra/SConscript
  • bsp/renesas/ra6e2-ek/ra/arm/CMSIS_6/CMSIS/Core/Include/a-profile/cmsis_armclang_a.h
  • bsp/renesas/ra6e2-ek/ra/arm/CMSIS_6/CMSIS/Core/Include/a-profile/cmsis_clang_a.h
  • bsp/renesas/ra6e2-ek/ra/arm/CMSIS_6/CMSIS/Core/Include/a-profile/cmsis_cp15.h
  • bsp/renesas/ra6e2-ek/ra/arm/CMSIS_6/CMSIS/Core/Include/a-profile/cmsis_gcc_a.h
  • bsp/renesas/ra6e2-ek/ra/arm/CMSIS_6/CMSIS/Core/Include/a-profile/cmsis_iccarm_a.h
  • bsp/renesas/ra6e2-ek/ra/arm/CMSIS_6/CMSIS/Core/Include/a-profile/irq_ctrl.h

🏷️ Tag: workflow

Reviewers: @Rbb666 @kurisaW @supperthomas

Changed Files (Click to expand)
  • .github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-09-22 22:41 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions bot added BSP action github action yml imporve BSP: Renesas BSP related with Renesas labels Aug 22, 2025
@Ouxiaolong Ouxiaolong changed the title add bsp ra6e2-ek [bsp/renesas] add bsp ra6e2-ek Aug 22, 2025
@Rbb666 Rbb666 requested a review from kurisaW August 23, 2025 03:29
@supperthomas
Copy link
Member

image

CI有问题。

@kurisaW
Copy link
Member

kurisaW commented Aug 25, 2025

image

这个看起来是fsp开启了某个bsp初始化内存的配置,看看能不能关掉,一般来说用不上

@kurisaW kurisaW closed this Aug 25, 2025
@kurisaW kurisaW reopened this Aug 25, 2025
@@ -0,0 +1,59 @@
menu "Hardware Drivers Config"

config SOC_R7FA6E2BB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请在这个目录下添加对应芯片的内核架构配置项:

https://github.com/RT-Thread/rt-thread/blob/master/bsp/renesas/libraries/Kconfig

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个架构已经有了,无需再定义吧
pic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

成功运行截图Snipaste_2025-08-26_22-22-08
Snipaste_2025-08-26_22-22-20

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有的话不用

@kurisaW
Copy link
Member

kurisaW commented Aug 25, 2025

另外请提交运行成功截图

@kurisaW kurisaW added the -1 No vote label Aug 26, 2025
@Ouxiaolong
Copy link
Contributor Author

image CI有问题。

这个应该是gcc编译的问题

@kurisaW
Copy link
Member

kurisaW commented Aug 27, 2025

image CI有问题。

这个应该是gcc编译的问题

这个你本地有测试过GCC编译和下载吗

@Ouxiaolong
Copy link
Contributor Author

如果没有问题请merge吧

@kurisaW
Copy link
Member

kurisaW commented Sep 11, 2025

你这个PR推送到主线肯定会出问题的,先把你本地和远端的分支进行同步吧,然后我在群里讲过考虑nano情况,如果有不清楚的群内沟通即可,可以参考这份PR:#10646

@kurisaW
Copy link
Member

kurisaW commented Sep 12, 2025

LGTM

| CAN | 支持 | |
| 持续更新中... | | |
| **外接外设** | **支持情况** | **备注** |
| WiFi 模块 | 支持 | [RW007 WiFi 网络模块](https://github.com/RT-Thread-packages/rw007) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme里面的这些外设有都测试过吗?
没有的还是先删除掉吧

1. [下载灵活配置软件包 (FSP) | Renesas](https://www.renesas.cn/zh/software-tool/flexible-software-package-fsp),请使用 FSP 6.0.0 版本。
2. 下载安装完成后,需要添加 EK-RA6E2 开发板的官方板级支持包。
> 打开[ EK-RA6E2 开发板详情页](https://www.renesas.cn/zh/design-resources/boards-kits/ek-ra6e2p),在**“下载”**列表中找到 **”EK-RA6E2板级支持包“**,点击链接即可下载。
3. 如何将 **”EK-RA6E2板级支持包“**添加到 FSP 中,请参考文档[如何导入板级支持包](https://www.renesas.cn/zh/software-tool/flexible-software-package-fsp)。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

markdown 语法有问题,请修正:

image

@Rbb666 Rbb666 closed this Sep 22, 2025
@Rbb666 Rbb666 reopened this Sep 22, 2025
@Rbb666 Rbb666 merged commit 1f38be3 into RT-Thread:master Sep 23, 2025
131 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action github action yml imporve BSP: Renesas BSP related with Renesas BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants