-
Couldn't load subscription status.
- Fork 5.3k
Fix stdio newlib v2 #10789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stdio newlib v2 #10789
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: @Maihuanyi Changed Files (Click to expand)
🏷️ Tag: components_libcReviewers: @GorrayLi @mysterywolf Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-10-11 14:28 CST)
📝 Review Instructions
|
|
|
|
AI给出的信息 你分析得完全正确: 更可靠的跨版本兼容方案目前的写法: #if defined(_REENT_SMALL) || !defined(__sdidinit)
// do nothing
#else
_GLOBAL_REENT->__sdidinit = 1;
#endif这种判断虽然可以解决部分情况,但通常 newlib 官方建议用更严谨的宏判断。实际上,newlib 从 3.4.0 开始逐步移除了 推荐做法
可选:用结构体成员检测宏(如
|
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
CLA没有通过,重新提交PR
对于下面的问题添加了详细的代码注释。
当前 RT-Thread 在使用 newlib 的部分版本时,会出现以下问题:
在
_GLOBAL_REENT结构中,旧版本使用的__sdidinit字段已被移除;_GLOBAL_REENT->__sdidinit,导致在编译 newlib 时出错;你的解决方案是什么 (what is your solution)
在
components/libc/posix/io/stdio.c/stdio.c中增加更合理的版本判断宏:#if defined(_REENT_SMALL) || !defined(__sdidinit)
// Newlib >= 3.4.0 or small reent version: no __sdidinit field
// Do nothing
#else
// Older newlib versions (typically < 3.4.0) still define __sdidinit
_GLOBAL_REENT->__sdidinit = 1;
#endif
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up